-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly version? #5
Comments
The Rust installs in the images are managed by rustup, so a simple approach would just be to run The official images have some rules around repeatability of images - not sure if there are exceptions for images intended to be non-repeatable like this one would be. @yosifkit Is this a thing that's come up before in other images? For some background, Rust publishes nightly builds of the compiler and standard libraries which allow use of unstable functionality which is not available on the standard versioned releases. If we added a "nightly" image, the specific version of the distribution it ended up with would vary across builds every day or so. |
Ah, somehow I didn't think of that approach, I've just done this for now: |
Cool - I believe all of the dependencies you're installing are already available on the buildpack image, bu the way: https://github.com/docker-library/buildpack-deps/blob/587934fb063d770d0611e94b57c9dd7a38edf928/stretch/Dockerfile#L3. |
Ha, you're probably right. I was using |
Any There is a related discussion in docker-library/official-images#1281. |
Thanks @yosifkit, that all makes sense. The option of a |
Would also love to see a nightly image. I think the additional rust-lang namespace should not be a problem to for most people, it's just a matter of knowing where to find it. |
I've started building this out: https://hub.docker.com/r/sfackler/rust/. It should trigger a rebuild every night. Don't depend on it for anything real yet - I'll be deleting that image when it's moved over to a rust-lang org. |
Thanks, appreciate it. In case you are interested in a use case for using the container locally (also interactively) and caching cargo downloads and builds, kindly have a look my repository where I wrapped around your containers to achieve that: https://github.com/andre-richter/docker-rust-persistent |
This is now set up: https://hub.docker.com/r/rustlang/rust/ |
Hmm, could this be reopened? Or will this repo never support rust nightly? I don't really understand the arguments against having it. Wouldn't you just have a script to update the build version each day, so it would still be repeatable? I'm currently using rustlang/rust, but it's currently blocked and I feel an official image would get better support. |
New versions of official images are produced by opening a pull request against https://github.com/docker-library/official-images with a new version of the library manifest file: https://github.com/docker-library/official-images/blob/master/library/rust. They are not going to merge an update very day forever. |
I didn't realise it was so manual. I was figuring this could all be done with bots. Ok, I'll find a workaround. It just kinda feels like the official image should support nightly. Thanks for the reply and your work on this anyway. |
I was trying to dockerize a Rocket app, and wanted to use the official Rust Docker image, but it seems there's no nightly?
Also, I'm new to Docker, so I may be mistaken.
The text was updated successfully, but these errors were encountered: