Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate the README files. #5

Closed
samreid opened this issue Oct 24, 2019 · 10 comments
Closed

Regenerate the README files. #5

samreid opened this issue Oct 24, 2019 · 10 comments

Comments

@samreid
Copy link
Member

samreid commented Oct 24, 2019

While I was working on phetsims/phet-info#120 I tested regenerating a README file, and it showed me that the README files are now missing this line:

git clone https://github.com/phetsims/utterance-queue.git
@zepumph
Copy link
Member

zepumph commented Nov 20, 2019

When I did the following commands, the utterance-queue line was added back in.

cd gravity-and-orbits
grunt published-readme

@samreid how would you recommend gathering a list of published repos to call grunt published-README on?

@zepumph zepumph assigned samreid and unassigned zepumph Nov 20, 2019
@samreid
Copy link
Member Author

samreid commented Nov 21, 2019

How about changing grunt update so that it automatically updates the README, based on looking at the versions in package.json?

@samreid samreid assigned zepumph and unassigned samreid Nov 21, 2019
@zepumph
Copy link
Member

zepumph commented Dec 10, 2019

This should be done soon. I should have already gotten to it as all published readmes are broken. Elevating priority.

zepumph added a commit to phetsims/chipper that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/equality-explorer-two-variables that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/balancing-chemical-equations that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/masses-and-springs-basics that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/forces-and-motion-basics that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/equality-explorer-basics that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/energy-skate-park-basics that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/energy-forms-and-changes that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/least-squares-regression that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/graphing-slope-intercept that referenced this issue Jan 15, 2020
zepumph added a commit to phetsims/function-builder-basics that referenced this issue Jan 15, 2020
@zepumph zepumph assigned samreid and unassigned zepumph Jan 15, 2020
zepumph added a commit to phetsims/projectile-motion that referenced this issue Jan 15, 2020
samreid added a commit to phetsims/chipper that referenced this issue Jan 17, 2020
samreid added a commit to phetsims/chipper that referenced this issue Jan 17, 2020
@samreid
Copy link
Member Author

samreid commented Jan 17, 2020

@zepumph this looks great, thanks! I made a few improvements in the commits. For dealing with the outliers in #5 (comment), I recommend adding a new package.json entry like "readmeTemplate:'...'" which is the relative path to the readme template to use. That way some repos can always use the "unpublished" template, and other sims can define their own template, which will be filled in with the template variables. Does that sound OK to you?

@samreid samreid assigned zepumph and unassigned samreid Jan 17, 2020
samreid added a commit to phetsims/perennial that referenced this issue Jan 21, 2020
@zepumph
Copy link
Member

zepumph commented Jan 22, 2020

That way some repos can always use the "unpublished" template, and other sims can define their own template, which will be filled in with the template variables. Does that sound OK to you?

I think this is halfway there. To me, when specifying something manually, you are opting out of both published and unpublished readmes, so I think instead there should be a package.json entry that tells grunt update to not try to auto generate the README.md file, since it is manual. I got to this solution via yours because in the outlier repos, it will involve having a template readme that is the exact same as the readme itself. I'll try a first pass and see what you think.

@zepumph
Copy link
Member

zepumph commented Jan 22, 2020

The above solution is working really well so far, and will cover permanent cases like blast, but doesn't cover the case where a brand new sim is in RC but not published. Is it alright to just say that it is ok to have a published readme for that case (upwards of a month or two of inconsistency once per new sim)?

zepumph added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/number-line-integers that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/coulombs-law that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/example-sim that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/simula-rasa that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/chipper that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/chains that referenced this issue Jan 22, 2020
zepumph added a commit to phetsims/blast that referenced this issue Jan 22, 2020
@zepumph
Copy link
Member

zepumph commented Jan 22, 2020

Summary of work:

  • Created readmeCreatedManually flag for package.json, and have grunt update respect it.
  • Add it to all of the above list save number line integers, and add chains to it.
  • run grunt update for all active sims and find that ISLC sims, though all have been published, had unpublished readmes (yay automation to find bugs).
  • Committed the change from unpublished to published for number line integers. @samreid please especially let me know what you think about this one.

One cleanup question I had was questioning if we have a central place where the schema for a sim (or general) package.json is defined. Should we make this? Otherwise there is no place to document readmeCreatedManually but to look at the usage. What do you think?
@samreid please review.

@samreid
Copy link
Member Author

samreid commented Jan 23, 2020

A note for when I review this: in phetsims/tasks#1018 we discussed improving the readme files. I wonder if we will want them to be templates so we can fill in the git clone dependencies?

@samreid
Copy link
Member Author

samreid commented Mar 13, 2020

Looks great, thanks! I moved phetsims/chipper#913 to a new issue. If we decide to make READMEs' based on templates, that can be done in phetsims/tasks#1018, closing.

@samreid samreid closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants