Skip to content

Commit

Permalink
Invert logic for isSimPublished, see phetsims/utterance-queue#5
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Jan 17, 2020
1 parent d3d9f86 commit ff9589b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
8 changes: 8 additions & 0 deletions js/SimVersion.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,14 @@ const assert = typeof module !== 'undefined' ? require( 'assert' ) : window && w
this.testType );
}

/**
* @returns {boolean}
* @public
*/
get isSimPublished() {
return !this.isSimNotPublished;
}

/**
* Takes a serialized form of the SimVersion and returns an actual instance.
* @public
Expand Down
9 changes: 2 additions & 7 deletions js/grunt/Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,15 +328,10 @@ module.exports = function( grunt ) {
grunt.task.run( 'generate-test-config' );
}

// update readmes only for simulations
// update README.md only for simulations
if ( packageObject.phet.simulation ) {
const simVersion = SimVersion.parse( packageObject.version );
if ( simVersion.isSimNotPublished ) {
generateREADME( repo, false /* not published */ );
}
else {
generateREADME( repo, true /* published */ );
}
generateREADME( repo, simVersion.isSimPublished );
}
} ) );

Expand Down

0 comments on commit ff9589b

Please sign in to comment.