Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily grunt work deleted important code #161

Closed
samreid opened this issue Jan 20, 2020 · 2 comments
Closed

Daily grunt work deleted important code #161

samreid opened this issue Jan 20, 2020 · 2 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jan 20, 2020

While working on phetsims/balancing-act#96, I ran grunt update from a phet-io change, and noticed that it generated an unpublished readme for balancing act. I tracked the problem down to a commit in which the daily grunt work deleted an important function:

phetsims/chipper@63d47a9

I'm unfamiliar with this script, so I'll assign it to the script's author. Also marking as high priority in case it is causing other problems.

@zepumph
Copy link
Member

zepumph commented Jan 21, 2020

Chippers SimVersion is copied from perennial each night. To make changes to the file you must commit to the one in perennial and it will be copied over. (or commit equally to both for a more immediate usage). It is noted at the top of the chipper version and perennial version. Please let me know how better the issue can be addressed if this linkage isn't documented well enough to you.

@samreid
Copy link
Member Author

samreid commented Jan 21, 2020

Thanks for the good information! I committed to perennial/SimVersion, closing.

@samreid samreid closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants