Regression test new A11y api improvements

[zepumph]

In #748 we will change a lot of the api for phet a11y. I want to make sure that no bugs slip by. One strategy for this will be to create dev links of the accessible sims so far to make sure that the future pDOMs look the same.

• BASE
  https://www.colorado.edu/physics/phet/dev/html/balloons-and-static-electricity/1.4.0-dev.14/phet/balloons-and-static-electricity_en_phet.html
  https://www.colorado.edu/physics/phet/dev/html/balloons-and-static-electricity/1.4.0-dev.14/phet/balloons-and-static-electricity_a11y_view.html

• JT
  https://www.colorado.edu/physics/phet/dev/html/john-travoltage/1.4.0-dev.4/phet/john-travoltage_en_phet.html
  https://www.colorado.edu/physics/phet/dev/html/john-travoltage/1.4.0-dev.4/phet/john-travoltage_a11y_view.html

• CL
  https://www.colorado.edu/physics/phet/dev/html/coulombs-law/1.0.0-dev.15/phet/coulombs-law_a11y_view.html
  https://www.colorado.edu/physics/phet/dev/html/coulombs-law/1.0.0-dev.15/phet/coulombs-law_en_phet.html

• Friction (mk)
  https://www.colorado.edu/physics/phet/dev/html/friction/1.5.0-dev.5/phet/friction_en_phet.html
  https://www.colorado.edu/physics/phet/dev/html/friction/1.5.0-dev.5/phet/friction_a11y_view.html

• Ohms Law (mk)
  https://www.colorado.edu/physics/phet/dev/html/ohms-law/1.4.0-dev.23/phet/ohms-law_en_phet.html
  https://www.colorado.edu/physics/phet/dev/html/ohms-law/1.4.0-dev.23/phet/ohms-law_a11y_view.html

• GFLB
  https://www.colorado.edu/physics/phet/dev/html/gravity-force-lab-basics/1.0.0-dev.21/phet/gravity-force-lab-basics_en_phet.html
  https://www.colorado.edu/physics/phet/dev/html/gravity-force-lab-basics/1.0.0-dev.21/phet/gravity-force-lab-basics_a11y_view.html

I think that will be enough.

Here is the rest of the simulations from the perennial/data/accessibility list that we need to look at:

• area-model-introduction
• build-an-atom (didn't look at, a11y not in active development)
• molarity
• molecules-and-light
• plinko-probability
• reactants-products-and-leftovers
• resistance-in-a-wire (mk)
• rutherford-scattering

on hold until that issue is done, I just wanted to make sure we got dev versions before beginning. Tagging @jessegreenberg because he is an amazing person that deserves to know everything.

[zepumph]

#748 is closed there will probably be places where prependLabels wasn't used, that now need appendLabel/appendDescription. These usages should be handled in this issue imo. Now we need to go through and make sure things are working. Assigning to all of us so we can handle our own sims in our own time. Let's meet back in a week and see what's left to do. Marking as high priority. Let me know if I am not clear about what this issue is about.

[zepumph]

@mbarlow12 @jessegreenberg please go through the sims listed in the first comment and mark your initial next to sims that you will go through, then we can split up any extras afterwards. Marking for dev meeting next week to discuss progress.

[zepumph]

I went through everything except BASE, it seemed pretty formulaic to change these, especially since there were snapshot dev versions. Here are a few conventions/philosophies I implemented/followed:

1. Removed all prependLabels option
2. Added appendDescription/Label: true defaults to radiobutton/checkboxes across the project. This was implemented because it is nice to have the label after these form elements (mainly this effects MAL)
3. In almost all places, there will still be work done to the sim, so I didn't spend all of the time in the world thinking through the pDOM, instead I just made sure the code made sense, and hadn't changed to previous versions.

Notes moving forward with this issue:

1. @jessegreenberg please note that BASE is all yours to make sure things look good (I see many usages of append options already).
2. @mbarlow12 I am the most uncertain about MAL, because I didn't make a snapshot before starting the api work, please be advised.
3. Please spot check you sims, and the sim specific commits above to make sure that all looks well.
4. Assign back to be or close when completed.

Thanks all!

[jessegreenberg]

I went through BASE, the PDOM looks great. We will be on the lookout, but things are looking good and stable. This issue can be closed, thank you for taking the lead @zepumph.