Skip to content

Commit

Permalink
coulombs law regression test, phetsims/scenery#753
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Apr 8, 2018
1 parent 4658e39 commit 4208f0b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
9 changes: 5 additions & 4 deletions js/HomeButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ define( function( require ) {

// a11y,
tagName: 'button',
labelContent: homeString,
innerContent: homeString,
containerTagName: 'li',
descriptionContent: homeScreenDescriptionString
descriptionContent: homeScreenDescriptionString,
appendDescription: true
}, options );

var homeIcon = new FontAwesomeNode( 'home' );
Expand All @@ -60,10 +61,10 @@ define( function( require ) {

// a11y - When you click on the home button in the nav bar, blur() that button when you go to the home screen.
this.addAccessibleInputListener( {
click: function(){
click: function() {
self.blur();
}
});
} );

// a11y - Pass a shape to the focusHighlight to prevent dilation, then tweak the bottom up just a hair so it
// isn't off the screen.
Expand Down
4 changes: 4 additions & 0 deletions js/HomeScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ define( function( require ) {
ScreenView.call( this, {
layoutBounds: LAYOUT_BOUNDS,
tandem: tandem,

// a11y
labelContent: homeScreenString
} );

Expand Down Expand Up @@ -97,10 +99,12 @@ define( function( require ) {
// large and small buttons are registered as separate instances. See https://github.com/phetsims/phet-io/issues/99
var largeTandem = tandem.createTandem( screen.screenTandem.tail + 'LargeButton' );

// a11y
var a11yScreenButtonOptions = {
tagName: 'button',
innerContent: screen.name,
descriptionContent: screen.descriptionContent,
appendDescription: true,
containerTagName: 'li'
};

Expand Down
1 change: 1 addition & 0 deletions js/NavigationBarScreenButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ define( function( require ) {
tagName: 'button',
containerTagName: 'li',
descriptionContent: screen.descriptionContent,
appendDescription: true,
innerContent: StringUtils.fillIn( screenNameStringPatternString, {
number: screenIndex + 1 // convert from index to display number
} )
Expand Down

0 comments on commit 4208f0b

Please sign in to comment.