Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redunant a11y option setters to default values #756

Closed
zepumph opened this issue Mar 31, 2018 · 2 comments
Closed

Remove redunant a11y option setters to default values #756

zepumph opened this issue Mar 31, 2018 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 31, 2018

Now with #748 we have default labels/description DOM elements, so often we can simplify code. Like:

new Node( {
 tagName: 'input'
 labelTagName: 'p',
 labelContent: 'This great label for input'
 descriptionTagName: 'p',
 descriptionContent: 'This is a description for the input',
 containerTagName: 'div'
});

would just be

new Node( {
  tagName: 'input'
  labelContent: 'This great label for input'
  descriptionContent: 'This is a description for the input',
 });

Marking for chip away, and tagging for a11 dev meeting.

@zepumph
Copy link
Member Author

zepumph commented Apr 8, 2018

Marking as high priority just so we can talk this week about it and all be on the same page.

@jessegreenberg
Copy link
Contributor

We talked about this at an a11y dev meeting, so we are all aware. Thanks for bringing it up @zepumph. We will be revisiting lots of a11y code as we progress with issues like #753. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants