Skip to content

Commit

Permalink
molecules-and-light regression, phetsims/scenery#753
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph authored and jessegreenberg committed Apr 21, 2021
1 parent c192a4b commit 0c96906
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 12 deletions.
3 changes: 1 addition & 2 deletions js/moleculesandlight/view/MoleculeSelectionPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,7 @@ define( function( require ) {
tagName: 'div',
labelTagName: 'h3',
labelContent: moleculesString,
descriptionContent: moleculesPanelDescriptionString,
prependLabels: true
descriptionContent: moleculesPanelDescriptionString
} );
}

Expand Down
4 changes: 3 additions & 1 deletion js/moleculesandlight/view/MoleculesAndLightScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ define( function( require ) {

// a11y
innerContent: stepButtonLabelString,
descriptionContent: stepButtonDescriptionString
descriptionContent: stepButtonDescriptionString,
appendDescription: true
} );
controlPanelSectionNode.addChild( stepButton );

Expand Down Expand Up @@ -210,6 +211,7 @@ define( function( require ) {
// a11y
innerContent: spectrumButtonLabelString,
descriptionContent: spectrumButtonDescriptionString,
appendDescription: true,
containerTagName: 'div'
} );

Expand Down
8 changes: 3 additions & 5 deletions js/moleculesandlight/view/ObservationWindow.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ define( function( require ) {
var StringUtils = require( 'PHETCOMMON/util/StringUtils' );
var Text = require( 'SCENERY/nodes/Text' );
var PhotonTarget = require( 'MOLECULES_AND_LIGHT/photon-absorption/model/PhotonTarget' );
var WavelengthConstants = require( 'MOLECULES_AND_LIGHT/photon-absorption/model/WavelengthConstants');
var WavelengthConstants = require( 'MOLECULES_AND_LIGHT/photon-absorption/model/WavelengthConstants' );
var Vector2 = require( 'DOT/Vector2' );

// phet-io modules
Expand Down Expand Up @@ -88,8 +88,7 @@ define( function( require ) {
// a11y
tagName: 'div',
labelTagName: 'h3',
labelContent: 'Observation Window',
prependLabels: true
labelContent: 'Observation Window'
} );

var self = this;
Expand Down Expand Up @@ -169,9 +168,8 @@ define( function( require ) {
tandem: tandem.createTandem( 'returnMoleculeButton' ),

// a11y
tagName: 'input',
inputType: 'button',
descriptionContent: returnMoleculeHelpString,
appendDescription: true,
ariaLabel: returnMoleculeString
} );

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ define( function( require ) {
tagName: 'div',
labelTagName: 'h3',
labelContent: lightSourceString,
descriptionContent: lightSourceDescriptionString,
prependLabels: true
descriptionContent: lightSourceDescriptionString
} );

// Initialize the photon nodes for the control panel. Identity model view transform is used because these photon
Expand Down
3 changes: 1 addition & 2 deletions js/moleculesandlight/view/SpectrumWindowDialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ define( function( require ) {

// a11y
tagName: 'p',
descriptionContent: spectrumWindowDescriptionString,
prependLabels: true
descriptionContent: spectrumWindowDescriptionString
} );

// close it on a click
Expand Down

0 comments on commit 0c96906

Please sign in to comment.