Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DownUpListener in old simulations doesn't have interrupt on the pointer listener #1222

Closed
jonathanolson opened this issue May 13, 2021 · 3 comments
Closed

DownUpListener in old simulations doesn't have interrupt on the pointer listener #1222

jonathanolson opened this issue May 13, 2021 · 3 comments
Labels
dev:maintenance-release

Comments

@jonathanolson
Copy link
Contributor

This is resulting in cases like phetsims/qa#642 (comment)
@jonathanolson jonathanolson self-assigned this May 13, 2021
@jonathanolson
Copy link
Contributor Author

https://github.com/phetsims/scenery/blob/425923b10754e1fec8b05976ae1f25e96f7ec0d7/js/input/DownUpListener.js is a case that doesn't handle interruption.

jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
4a71908
jonathanolson added a commit to phetsims/area-model-algebra that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
5fb831e
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
1d53902
jonathanolson added a commit to phetsims/area-model-decimals that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
4c5f054
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
bd8a0c5
jonathanolson added a commit to phetsims/area-model-introduction that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
fded6a3
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
ac4a099
jonathanolson added a commit to phetsims/area-model-multiplication that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
09e6600
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListenert for #1222
3c7125f
jonathanolson added a commit to phetsims/atomic-interactions that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
f517a40
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
e6e696e
jonathanolson added a commit to phetsims/balancing-act that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
913ab34
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
17bf32e
jonathanolson added a commit to phetsims/balancing-chemical-equations that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
76c9a8f
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
e9895c5
jonathanolson added a commit to phetsims/balloons-and-static-electricity that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
442449c
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
3a355a7
jonathanolson added a commit to phetsims/blackbody-spectrum that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
c871be4
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
d76831a
jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
8348c10
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListenert for #1222
a1badfc
jonathanolson added a commit to phetsims/build-a-molecule that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
fa02a87
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
f47aadf
jonathanolson added a commit to phetsims/build-an-atom that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
82d0830
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt to DownUpListener, see #1222
e55b75a
jonathanolson added a commit to phetsims/capacitor-lab-basics that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/scenery#1222
196a213
jonathanolson added a commit to phetsims/graphing-quadratics that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.1.6, phetsims/scenery#1199, phetsims/chipper#1032,
a66cfb1 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/graphing-slope-intercept that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.1.10, phetsims/scenery#1199, phetsims/scenery#983,
d950628 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/gravity-force-lab that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 2.2.3, phetsims/scenery#1199, phetsims/chipper#1032,
1549355 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/gravity-force-lab-basics that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.3, phetsims/scenery#1199, phetsims/scenery#1218,
1d096ce 
phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.1.10, phetsims/scenery#1199, phetsims/scenery#983,
14a5950 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/john-travoltage that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.5.13, phetsims/scenery#1199, phetsims/scenery#983,
c551047 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/masses-and-springs that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.11, phetsims/scenery#1199, phetsims/scenery#983,
21195d1 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/masses-and-springs-basics that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.10, phetsims/scenery#1199, phetsims/scenery#983,
fce96c6 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/molarity that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.4.13, phetsims/scenery#1199, phetsims/phet-io#1742…
4a0ff0b 
…, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/scenery#1224
jonathanolson added a commit to phetsims/molarity that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.5.3, phetsims/scenery#1199, phetsims/scenery#1218,
a96a18d 
phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/molecule-polarity that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.16, phetsims/scenery#1199, phetsims/scenery#983,
20867a9 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717
jonathanolson added a commit to phetsims/molecule-shapes that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.2.9, phetsims/scenery#1199, phetsims/scenery#983, …
6445bcb 
…phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, #179
jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.2.9, phetsims/scenery#1199, phetsims/scenery#983, …
93040f1 
…phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/molecule-shapes#179
jonathanolson added a commit to phetsims/molecules-and-light that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.5.9, phetsims/scenery#1199, phetsims/scenery#1218,
2e96953 
phetsims/scenery#1222
jonathanolson added a commit to phetsims/ohms-law that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.4.10, phetsims/scenery#1199, phetsims/scenery#983,
993755d 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/pendulum-lab that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.16, phetsims/scenery#1199, phetsims/scenery#983,
cbe6ce0 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717
jonathanolson added a commit to phetsims/ph-scale that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.3.5, phetsims/scenery#1199, phetsims/scenery#983, …
c99d9a3 
…phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.3.5, phetsims/scenery#1199, phetsims/scenery#983, …
5c9b682 
…phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/projectile-motion that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.16, phetsims/scenery#1199, phetsims/scenery#983,
2f225bd 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/joist#717
jonathanolson added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.2.12, phetsims/scenery#1199, phetsims/scenery#983,
cbf5f8e 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/resistance-in-a-wire that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.3.13, phetsims/scenery#1199, phetsims/capacitor-…
8df84c9 
…lab-basics#291, phetsims/scenery#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/scenery#1224
jonathanolson added a commit to phetsims/resistance-in-a-wire that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.6.11, phetsims/scenery#1199, phetsims/scenery#983,
176f50a 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/rutherford-scattering that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.1.10, phetsims/scenery#1199, phetsims/scenery#983,
848ed9c 
phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/states-of-matter that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.2.2, phetsims/scenery#1199, phetsims/scenery#1218,
7669abc 
phetsims/joist#641, phetsims/scenery#1222
jonathanolson added a commit to phetsims/states-of-matter-basics that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.2.1, phetsims/scenery#1199, phetsims/scenery#1218,
6a1b360 
phetsims/joist#641, phetsims/scenery#1222
jonathanolson added a commit to phetsims/vector-addition that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.1, phetsims/scenery#1199, phetsims/scenery#1218,
55fe413 
phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/vector-addition-equations that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.1, phetsims/scenery#1199, phetsims/scenery#1218,
dbf014a 
phetsims/joist#714, phetsims/scenery#1222
jonathanolson added a commit to phetsims/wave-interference that referenced this issue Jun 18, 2021
@jonathanolson
Bumping version to 2.0.3, phetsims/scenery#1199, phetsims/scenery#1218,
ca59a64 
phetsims/joist#714, phetsims/scenery#1222
@jonathanolson
Copy link
Contributor Author

Closing, handled in maintenance release deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:maintenance-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathanolson