Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Molecule drag is not interrupted when released out of frame #179

Closed
phet-steele opened this issue May 4, 2021 · 2 comments
Closed

Molecule drag is not interrupted when released out of frame #179

phet-steele opened this issue May 4, 2021 · 2 comments
Labels
dev:maintenance-release type:bug

Comments

@phet-steele
Copy link

Tested during phetsims/qa/issues/642 but originally reported in phetsims/qa#630 (comment), what is described in that comment still occurs, but there was never any explanation as to why it happens or if this needs to be fixed. (Found on Win 10 Chrome) I'm making this issue now for more proper documentation. 👍
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt for #179
3fb28a1
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding interrupt for #179
5140d05
jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/molecule-shapes#179
dd4fc61
@jonathanolson
Copy link
Contributor

Patched, will wait on QA.

@jonathanolson jonathanolson removed their assignment May 13, 2021
jonathanolson added a commit that referenced this issue May 14, 2021
@jonathanolson
Bumping version to 1.2.9-rc.2, phetsims/scenery#1199, phetsims/scener…
1f2bb87 
…y#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, #179
jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue May 14, 2021
@jonathanolson
Bumping version to 1.2.9-rc.2, phetsims/scenery#1199, phetsims/scener…
099d443 
…y#983, phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/molecule-shapes#179
This was referenced May 14, 2021
Closed
Closed
@phet-steele
Copy link
Author

Seems to work well enough in phetsims/qa/issues/649.

@jonathanolson jonathanolson mentioned this issue Jun 2, 2021
Closed
@jonathanolson jonathanolson mentioned this issue Jun 10, 2021
Closed
jonathanolson added a commit that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.2.9, phetsims/scenery#1199, phetsims/scenery#983, …
6445bcb 
…phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, #179
jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.2.9, phetsims/scenery#1199, phetsims/scenery#983, …
93040f1 
…phetsims/scenery#1218, phetsims/joist#714, phetsims/scenery#1222, phetsims/molecule-shapes#179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:maintenance-release type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @phet-steele