Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance release for initialScreen/homeScreen query parameters #714

Closed
jonathanolson opened this issue May 7, 2021 · 6 comments
Closed

Comments

@jonathanolson
Copy link
Contributor

It would be good to have this added to sims retroactively where needed.

@jonathanolson jonathanolson self-assigned this May 7, 2021
@jonathanolson jonathanolson changed the title Maintenance release for initialScreen query parameter Maintenance release for initialScreen/homeScreen query parameters May 7, 2021
@jonathanolson
Copy link
Contributor Author

See phetsims/qa#642 (comment) for sims

@jonathanolson
Copy link
Contributor Author

Patched the "broken" homescreen cases with patches for #641

@jonathanolson
Copy link
Contributor Author

Looks like explicit decisions were made to error out and not launch simulations when one screen was visible:

      // Problems related to query parameters throw errors instead of assertions (so they are not stripped out)
      if ( QueryStringMachine.containsKey( 'homeScreen' ) ) {
        throw new Error( 'homeScreen query parameter not supported for single-screen sims' );
      }
      if ( QueryStringMachine.containsKey( 'initialScreen' ) ) {
        throw new Error( 'initialScreen query parameter not supported for single-screen sims' );
      }
      if ( QueryStringMachine.containsKey( 'screens' ) ) {
        throw new Error( 'screens query parameter not supported for single-screen sims' );
      }

We don't do that in master... should I remove the explicit errors?

jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/area-builder that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/arithmetic that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/balancing-act that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/beers-law-lab that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/bending-light that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/charges-and-fields that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/color-vision that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/color-vision that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/concentration that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/concentration that referenced this issue May 12, 2021
jonathanolson added a commit to phetsims/molecules-and-light that referenced this issue Jun 17, 2021
@jonathanolson
Copy link
Contributor Author

Closing, handled in maintenance release deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants