-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance release for initialScreen/homeScreen query parameters #714
Labels
Comments
jonathanolson
changed the title
Maintenance release for initialScreen query parameter
Maintenance release for initialScreen/homeScreen query parameters
May 7, 2021
See phetsims/qa#642 (comment) for sims |
Patched the "broken" homescreen cases with patches for #641 |
Looks like explicit decisions were made to error out and not launch simulations when one screen was visible: // Problems related to query parameters throw errors instead of assertions (so they are not stripped out)
if ( QueryStringMachine.containsKey( 'homeScreen' ) ) {
throw new Error( 'homeScreen query parameter not supported for single-screen sims' );
}
if ( QueryStringMachine.containsKey( 'initialScreen' ) ) {
throw new Error( 'initialScreen query parameter not supported for single-screen sims' );
}
if ( QueryStringMachine.containsKey( 'screens' ) ) {
throw new Error( 'screens query parameter not supported for single-screen sims' );
} We don't do that in master... should I remove the explicit errors? |
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/acid-base-solutions
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/area-builder
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/arithmetic
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/balancing-act
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/beers-law-lab
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/bending-light
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/charges-and-fields
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/color-vision
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/color-vision
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/concentration
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/chipper
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/concentration
that referenced
this issue
May 12, 2021
jonathanolson
added a commit
to phetsims/make-a-ten
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/masses-and-springs
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/masses-and-springs-basics
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/molarity
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/molarity
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/molecule-polarity
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/molecule-shapes
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/molecule-shapes-basics
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/molecules-and-light
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/neuron
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/ohms-law
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/pendulum-lab
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/ph-scale
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/ph-scale-basics
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/plinko-probability
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/projectile-motion
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/proportion-playground
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/reactants-products-and-leftovers
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/resistance-in-a-wire
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/resistance-in-a-wire
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/rutherford-scattering
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/trig-tour
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/under-pressure
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/unit-rates
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/vector-addition
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/vector-addition-equations
that referenced
this issue
Jun 17, 2021
jonathanolson
added a commit
to phetsims/wave-interference
that referenced
this issue
Jun 18, 2021
jonathanolson
added a commit
to phetsims/wave-on-a-string
that referenced
this issue
Jun 18, 2021
Closing, handled in maintenance release deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be good to have this added to sims retroactively where needed.
The text was updated successfully, but these errors were encountered: