Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror Wrapper is out of synch #1224

Closed
KatieWoe opened this issue May 19, 2021 · 10 comments
Closed

Mirror Wrapper is out of synch #1224

KatieWoe opened this issue May 19, 2021 · 10 comments
Assignees
Labels

Comments

@KatieWoe
Copy link

For phetsims/qa#649. Seen on Win 10 Chrome in https://phet-dev.colorado.edu/html/capacitor-lab-basics/1.6.20-rc.3/phet-io/wrappers/mirror-inputs/mirror-inputs.html.
If you drag something outside the the top iframe, let go, then return, the top frame drops the item and the bottom doesn't, leading to an out-of-synch mirror wrapper.
outofsynch

@KatieWoe
Copy link
Author

Can also happen with the about dialog so may connect to #1218 (comment)
outofsynchmore

@KatieWoe
Copy link
Author

Happens in Resistance in a Wire

@phet-steele
Copy link
Contributor

Happens in Molarity.

jonathanolson added a commit that referenced this issue May 24, 2021
jonathanolson added a commit to phetsims/capacitor-lab-basics that referenced this issue May 24, 2021
jonathanolson added a commit that referenced this issue May 24, 2021
jonathanolson added a commit to phetsims/molarity that referenced this issue May 24, 2021
jonathanolson added a commit that referenced this issue May 24, 2021
jonathanolson added a commit to phetsims/resistance-in-a-wire that referenced this issue May 24, 2021
@jonathanolson
Copy link
Contributor

Patched in the above 3 simulations. Was this an exhaustive list for what sims had this issue?

@KatieWoe
Copy link
Author

I think so, but many couldn't be checked as they didn't load.

@KatieWoe
Copy link
Author

KatieWoe commented Jun 7, 2021

For phetsims/qa#653, since some sims don't load the mirror wrapper (I think this is expected) we are unable to confirm those issues for those sims. @jonathanolson how do you want us to handle those sims?

@jonathanolson
Copy link
Contributor

@KatieWoe is there a good way to check deployed sims for this?

@KatieWoe
Copy link
Author

If there are links to the deployed versions of the phet-io sims we could go through them

@jonathanolson
Copy link
Contributor

jonathanolson commented Jun 18, 2021

I don't have an easy way to filter to just phet-io links, but here are the links:

acid-base-solutions 1.2 ()

area-builder 1.1 ()

area-model-algebra 1.2 ()

area-model-decimals 1.2 ()

area-model-introduction 1.2 ()

area-model-multiplication 1.2 ()

arithmetic 1.0 ()

atomic-interactions 1.2 ()

balancing-act 1.1 ()

balancing-act 1.2 ()

balancing-chemical-equations 1.2 ()

balloons-and-static-electricity 1.3-phetio ()

balloons-and-static-electricity 1.4 ()

beers-law-lab 1.4 ()

beers-law-lab 1.6-phetio ()

bending-light 1.1 ()

blackbody-spectrum 1.0 ()

build-a-fraction 1.0 ()

build-a-molecule 1.0 ()

build-an-atom 1.5-phetio ()

build-an-atom 1.6 ()

capacitor-lab-basics 1.6 ()

charges-and-fields 1.0 ()

charges-and-fields 1.0-phetio ()

circuit-construction-kit-black-box-study 1.1-phetio ()

circuit-construction-kit-dc 1.2 ()

circuit-construction-kit-dc-virtual-lab 1.2 ()

collision-lab 1.1 ()

color-vision 1.1 ()

color-vision 1.2-phetio ()

concentration 1.3 ()

concentration 1.5-phetio ()

coulombs-law 1.0 ()

curve-fitting 1.0 ()

diffusion 1.0 ()

energy-forms-and-changes 1.4 ()

energy-skate-park 1.1 ()

energy-skate-park-basics 1.1 ()

energy-skate-park-basics 1.3-phetio ()

equality-explorer 1.0 ()

equality-explorer-basics 1.0 ()

equality-explorer-two-variables 1.0 ()

expression-exchange 1.1 ()

faradays-law 1.3-phetio ()

faradays-law 1.4 ()

forces-and-motion-basics 2.1-phetio ()

forces-and-motion-basics 2.3 ()

fraction-matcher 1.2 ()

fractions-equality 1.1 ()

fractions-intro 1.0 ()

fractions-mixed-numbers 1.0 ()

friction 1.5 ()

function-builder 1.0 ()

function-builder-basics 1.0 ()

gas-properties 1.0 ()

gases-intro 1.0 ()

gene-expression-essentials 1.0 ()

graphing-lines 1.3 ()

graphing-quadratics 1.1 ()

graphing-slope-intercept 1.1 ()

gravity-and-orbits 1.4 ()

gravity-force-lab 2.2 ()

gravity-force-lab-basics 1.0 ()

hookes-law 1.0 ()

isotopes-and-atomic-mass 1.1 ()

john-travoltage 1.4-phetio ()

john-travoltage 1.5 ()

least-squares-regression 1.1 ()

make-a-ten 1.0 ()

masses-and-springs 1.0 ()

masses-and-springs-basics 1.0 ()

molarity 1.4 ()

molarity 1.5 ()

molecule-polarity 1.0 ()

molecule-shapes 1.2 ()

molecule-shapes-basics 1.2 ()

molecules-and-light 1.3-phetio ()

molecules-and-light 1.5 ()

natural-selection 1.1 ()

natural-selection 1.2 ()

natural-selection 1.3 ()

neuron 1.1 ()

number-line-integers 1.1 ()

number-line-operations 1.0 ()

ohms-law 1.4 ()

pendulum-lab 1.0 ()

ph-scale 1.3 ()

ph-scale-basics 1.3 ()

plinko-probability 1.1 ()

projectile-motion 1.0 ()

proportion-playground 1.0 ()

ratio-and-proportion 1.0 ()

reactants-products-and-leftovers 1.2 ()

resistance-in-a-wire 1.3-phetio ()

resistance-in-a-wire 1.6 ()

rutherford-scattering 1.1 ()

states-of-matter 1.2 ()

states-of-matter-basics 1.2 ()

trig-tour 1.0 ()

under-pressure 1.1 ()

unit-rates 1.0 ()

vector-addition 1.0 ()

vector-addition-equations 1.0 ()

wave-interference 2.0 ()

wave-on-a-string 1.1 ()

waves-intro 1.1 ()

@jonathanolson jonathanolson removed their assignment Jun 18, 2021
@KatieWoe
Copy link
Author

They look good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants