Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TypeScript #80

Closed
pixelzoom opened this issue Feb 23, 2023 · 2 comments
Closed

Convert to TypeScript #80

pixelzoom opened this issue Feb 23, 2023 · 2 comments
Assignees
@pixelzoom
Labels
dev:typescript

Comments

@pixelzoom
Copy link
Contributor

This is a prerequisite for #78 and #79.
@pixelzoom pixelzoom self-assigned this Feb 23, 2023
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
c00dca8
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
6d46c3e
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
dfa1996
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
9ddd333
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
874fd7f
@pixelzoom
Copy link
Contributor Author

After converting a few files in the above commits, it occurred to me that I should publish a baseline version. Here it is: https://phet-dev.colorado.edu/html/reactants-products-and-leftovers/1.3.0-dev.3/phet/reactants-products-and-leftovers_all_phet.html

pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
af4f2d0
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
make RPALSymbols TS compatible, #80
e983009
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
replace static methods with clone(), #80
fafd98f
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
move MOLECULE_NODE_CONSTRUCTORS to RPALRewardFactory, #80
9e870f1
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
doc FACE_COLORS, generate FaceNode using FACE_COLORS.map, #80
d56234a
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
use MOLECULE_NODE_CONSTRUCTORS.map, #80
03489d0
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
d941386
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
a37aae3
pixelzoom added a commit that referenced this issue Feb 24, 2023
@pixelzoom
convert to TypeScript, #80
4b0ec97
pixelzoom added a commit that referenced this issue Feb 28, 2023
@pixelzoom
convert to TypeScript, #80
dcd3d3a
pixelzoom added a commit that referenced this issue Feb 28, 2023
@pixelzoom
replace Property.get() with Property.value , #80
bbae384
pixelzoom added a commit that referenced this issue Feb 28, 2023
@pixelzoom
replace Property.set() with Property.value , #80
e4f869d
pixelzoom added a commit that referenced this issue Feb 28, 2023
@pixelzoom
convert to TypeScript, #80
7e263d5
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
9d5878d
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
3ce0588
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
326de5a
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
05960a6
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
fffcd90
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
592a88a
@pixelzoom pixelzoom mentioned this issue Mar 1, 2023
Closed
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
2b69d5f
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
0601ee0
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
2490165
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
b2d2db2
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
replace merge, #80
39abb60
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
fix centering of NumberNode, #80
536023f
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
formatting, #80
1143ccf
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
clean up ScreenView subclasses to improve readability, #80
f885deb
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
0bed968
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
f0451e3
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
9620fe6
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
6b72155
pixelzoom added a commit that referenced this issue Mar 1, 2023
@pixelzoom
convert to TypeScript, #80
657d7c7
@pixelzoom pixelzoom mentioned this issue Mar 2, 2023
Closed
17 tasks
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
04fc7c2
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
3a2e608
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
4320714
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
6bed9cb
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
47595e5
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
e982126
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
9309dde
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
1be7e9f
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
36cfae1
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
convert to TypeScript, #80
bae1b8f
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
TODO, #80
bd33e33
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
add eslintConfig.overrides to package.json, #80
9579ea3
@pixelzoom
Copy link
Contributor Author

TypeScript conversion is done. There was 1 @ts-expect-error added, to be addressed in #83.

Closing.

pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
replace merge with combineOptions, #80
6c938e5
pixelzoom added a commit that referenced this issue Mar 2, 2023
@pixelzoom
add explicity type for CreateEquationNodeFunction, #80
8f9dc43
pixelzoom added a commit that referenced this issue Mar 3, 2023
@pixelzoom
delete redundant JSdoc type expressions, #80
877f6b0
pixelzoom added a commit that referenced this issue Mar 3, 2023
@pixelzoom
remove eslint-disable, #80
bfca4e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom