Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address @ts-expect-error #83

Closed
pixelzoom opened this issue Mar 2, 2023 · 1 comment
Closed

Address @ts-expect-error #83

pixelzoom opened this issue Mar 2, 2023 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

There is 1 @ts-expect-error that's a tricky to address, in SandwichesScreenView.ts. I suspect that it may go away during PhET-iO instrumentation #78, because it's related to something that needs to be converted from dynamic to static instantiation. I'll leave this issue open, and circle back later.

When this @ts-expect-error has been removed, then this change needs to be made to package.json:

        "rules": {
-         "@typescript-eslint/no-explicit-any": "error"
+         "@typescript-eslint/no-explicit-any": "error",
+         "@typescript-eslint/ban-ts-comment": "error"
        }
@pixelzoom
Copy link
Contributor Author

Addressed in the above commit, and updated package.json. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant