doc FACE_COLORS, generate FaceNode using FACE_COLORS.map, #80

phetsims · Feb 24, 2023 · d56234a · d56234a
1 parent 9e870f1
commit d56234a
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/js/game/view/RPALRewardNode.js b/js/game/view/RPALRewardNode.js
@@ -55,7 +55,6 @@ import SandwichNode from '../../sandwiches/view/SandwichNode.js';
 
 // constants
 const NUMBER_OF_NODES = 100;
-const FACE_COLORS = [ 'yellow', 'rgb(255,85,0)', 'orange', 'magenta', 'cyan', 'rgb(100,255,100)' ];
 
 // constructors for all atoms & molecules that appear in reactions, to appear in Level 1 reward
 const MOLECULE_NODE_CONSTRUCTORS = [
@@ -69,6 +68,9 @@ const MOLECULE_NODE_CONSTRUCTORS = [
   SNode, SO2Node, SO3Node
 ];
 
+// Smiley face colors, to appear in Level 2 reward
+const FACE_COLORS = [ 'yellow', 'rgb(255,85,0)', 'orange', 'magenta', 'cyan', 'rgb(100,255,100)' ];
+
 export default class RPALRewardNode extends RewardNode {
 
   /**
@@ -89,10 +91,7 @@ function createNodesLevel1() {
 
 // Level 2: smiley faces (various colors), @returns {Node[]}
 function createNodesLevel2() {
-  const nodes = [];
-  FACE_COLORS.forEach( color => {
-    nodes.push( new FaceNode( 40, { headFill: color } ) );
-  } );
+  const nodes = FACE_COLORS.map( color => new FaceNode( 40, { headFill: color } ) );
   return RewardNode.createRandomNodes( nodes, NUMBER_OF_NODES );
 }