-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context responses need updating for single hands #419
Comments
As mentioned in meeting, the context responses that are currently firing for the indy hand sliders is not working properly. I went a tested the Interactive Description for the same version and that is also not working, but in the exact opposite way. In both cases I hear the appropriate object responses, but not the appropriate context responses:
FYI, I also tested the published sim's Interactive Description, and while the two different context responses are firing there is a least 1 bug and some room for improvement. The bug us sometimes and I can figure out when, I hear hear the incorrect distance-progress string (I will create a separate issue for this if one doesn't already exist). In terms of clarifying the improvements we need, I am thinking it through, and will comment again asap. The previous comment (#419 (comment)) is indeed one idea that I think would make the experience better. |
Above I commented out the description context response so that you can test what is currently implemented. It was a little different from what we discussed on friday. When in the same distance-region, it will alternate between that distance region and the distance progress region:
Just so you can know. This most likely shouldn't change how we are going to proceed with voicing. |
(Adding) Yes, this logic seems good to me. As I mentioned in today's meeting this alternating logic should gracefully handle single-value regions like:
And then we will hopefully only have one edge case
I think pedagogically it is better to provide distance region rather than distance progress when the learner hits the challenge. Reasoning is that I think they need to connect the approximate distance between the hands (distance region), their position (position region) and the being at the challenge ratio. The distance-progress string is not the information they need when they reach the challenge. |
All the distance regions were covered by the bug fix in #416. Above I made sure that in-proportion will never have distance progress either. Please review, does all look right to you @terracoda? |
@zepumph, I think we are onto something good here, but we have lost "position-region" for mouse exploration. It's so hard to tell which string is what since they all three are so qualitative, so I am going to repeat it here. We have three possible dynamic strings in context responses:
Ignoring the fact that some of the position-regions are single value landmarks (at top, at middle, at bottom), we originally had 2 possible arrangements for context responses: Note that this is still true for keyboard exploration. Pedagogical Needs Design Questions
Next Steps: Bugs Possible General Improvements |
@zepumph, can you comment on or work on my suggestions for Next Steps (above)? Once we get that sorted, we can work on narrowing down the Bug that I mentioned. |
Ugg, yes, I'm so sorry that I ditched the position regions, my mistake. I guess my mind was way too involved on the distance side of things. You can test above. The bug and potential improvement have been moved to separate issues. |
@terracoda, at this time, I believe that the keyboard interaction (voicing and description) is also ready for review. |
There are more bugs visual and and text related:
But on the positive side, I think the distance-region and distance-progress parameters are implemented correctly. I have only tried no tick marks and default key presses. |
|
@zepumph, I think the context responses sound really good in interactive description. I tried 3 different voice rates:
These all sounded good to me. There was one time when I landed on challenge ratio when using rate 60 and the context response felt a tiny bit delayed. But I did a few more things and it did not seem delayed. I am closing this issue. |
It might sound different in other screen readers, but I think we can leave timing tweaks alone for now. |
From #413.
The text was updated successfully, but these errors were encountered: