Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DragListener end drag utterance should not interrupt onchange? #422

Closed
zepumph opened this issue Jan 24, 2022 · 3 comments
Closed

DragListener end drag utterance should not interrupt onchange? #422

zepumph opened this issue Jan 24, 2022 · 3 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jan 24, 2022

From #419, @terracoda said:

Just noting that at the end of drag, i.e., the release of a hand, the interruption sometimes is less than ideal. This also happens in GFLB, so any improvement or solution here will be a general one. No action required at this time, just something to think about, in general for Voicing and sliders.

This would most likely be an easy fix, but I would want to try it out in an isolated issue (+ isolated testing) to make sure it is as we want it to me. Something to do a bit later, once the initial implementation is set.

@zepumph zepumph added dev:enhancement New feature or request dev:voicing labels Jan 24, 2022
@zepumph zepumph self-assigned this Jan 24, 2022
@zepumph zepumph assigned terracoda and unassigned zepumph Mar 2, 2022
@zepumph
Copy link
Member Author

zepumph commented Mar 2, 2022

Current behavior: the response during drag and the response at the end of a drag are both powered by the same Utterance, so they interrupt each other.

Desired behavior (as I understand it):

  • While dragging, each new description would still interrupt the previous one, to have the most up-to-date info while dragging
  • When you let go, the end drag response doesn't interrupt the drag response currently being spoken. Instead, it will be spoken afterwards.

`@terracoda, now that #413 is closed out, can you comment on this issue. I personally don't see this change as an obvious improvement. There are many cases where the drag info would be out of date (wouldn't state it is in proportion, doesn't account for snapping behavior, etc). Do you still want me to implement this?

@terracoda
Copy link
Contributor

You are absolutely correct, we can still have things out of date, and this solution might preserve the issue described in #439, rather than improve the experience.

Marking this on hold.

@zepumph
Copy link
Member Author

zepumph commented Jun 24, 2022

This seems less than ideal because we don't want out of date information (from the remainder of the drag response). Closing

@zepumph zepumph closed this as completed Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants