-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HandPositionsDescriber.getDistanceProgressString()
is not idempotent
#416
Labels
Comments
This was referenced Dec 3, 2021
This would be nice to do so that @terracoda can test voicing with distance-region AND distance-progress these days
|
Committed in 71ae824 |
Fixed above, it was easiest to create a separate instance of HandPositionsDescriber that was just for voicing. Then I also had to split up the "previous" region for both hands vs single. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are running into a problem here over in #413 because we want to use the "closer/farther" distance-progress strings in both description and voicing. When you call that function, it registers the previous value and overwrites the distance. It was designed to be called only when delivering an alert to the user during interaction. So in addition to the challenge of using it for both description and voicing, updating it eagerly, like we do for the object response, will not work.
The text was updated successfully, but these errors were encountered: