Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HandPositionDescriber should not be dependency injected #458

Closed
zepumph opened this issue Apr 6, 2022 · 1 comment
Closed

HandPositionDescriber should not be dependency injected #458

zepumph opened this issue Apr 6, 2022 · 1 comment
Assignees
@zepumph

Comments

@zepumph
Copy link
Member

zepumph commented Apr 6, 2022

From item 3 in #432 (comment) and #416, this is buggy to have different text-output modalities (voicing and description) share the same state for the hand position describer. This is messing up the distance progress/region logic for the both hands interaction.
@zepumph zepumph self-assigned this Apr 6, 2022
@zepumph zepumph mentioned this issue Apr 6, 2022
Closed
zepumph added a commit that referenced this issue Apr 6, 2022
@zepumph
BothHandsDescriber should creat its own HandPositionsDescriber, #458
6ab8f16
@zepumph
Copy link
Member Author

zepumph commented Apr 6, 2022

I had good luck with this new strategy. I will take this to the next space that I create describers.

@zepumph zepumph closed this as completed Apr 6, 2022
zepumph added a commit that referenced this issue Apr 6, 2022
@zepumph
Create describers as needed, for individual use cases, #458
79d6549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph