Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object response needs to be always updated so it is correct on focus #425

Closed
zepumph opened this issue Jan 28, 2022 · 2 comments
Closed

Comments

@zepumph
Copy link
Member

zepumph commented Jan 28, 2022

From #419 (comment). Just like with ariaValueTet in AccessibleValueHandler, we should always update the object reponse whenever the valueProperty or a11y dependencies change:

Here:

https://github.com/phetsims/sun/blob/877f09991f4ae29029c2a7c8215d814318b6a91d/js/accessibility/AccessibleValueHandler.ts#L433

@zepumph zepumph self-assigned this Jan 28, 2022
zepumph added a commit to phetsims/sun that referenced this issue Jan 28, 2022
…te responses with null, update objectRespones based on a11yDependencies, phetsims/ratio-and-proportion#425 #730
@zepumph
Copy link
Member Author

zepumph commented Jan 28, 2022

Alright, fixed above. @terracoda please review. Anything else here?

@terracoda
Copy link
Contributor

The object responses are updating. The keyboard arrow icons are still present after movement, but that will be part of a different issue.

And I am not hearing the chime when using keyboard. You made an issue for that.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants