Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: wave-interference/2.0.0-dev.7 and wave-intro/1.0.0-dev.10 #389

Closed
4 tasks done
samreid opened this issue Jul 30, 2019 · 9 comments
Closed
4 tasks done

Dev Test: wave-interference/2.0.0-dev.7 and wave-intro/1.0.0-dev.10 #389

samreid opened this issue Jul 30, 2019 · 9 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@samreid
Copy link
Member

samreid commented Jul 30, 2019

@ariel-phet @KatieWoe @kathy-phet and @arouinfar, wave-interference/2.0.0-dev.7 and wave-intro/1.0.0-dev.10 are ready for dev testing. In previous discussion, we have said RC testing Aug 1 would be good and that it would be good to publish Wave Interference by the end of summer. I have combined these two tests since they have the same SHAs and will be maintained together. Please document issues in https://github.com/phetsims/wave-interference/issues and link to this issue.

Assigning @ariel-phet for prioritization.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • If there is a console available, check for errors and include them in the Problem Description.

Focus and Special Instructions

In Wave Interference, there are two main new features. (a) the "Diffraction" screen, which has previously been through a dev test in #322 and (b) which is the "Play Tone" feature in the Waves Screen. However, other features in all screens have changed, so the sim will need a thorough test. Waves Intro is a new sim which shows one scene per screen and also has the "Play Tone" feature. This is the first dev test for Waves Intro. No PhET-iO or A11y for either sim in this dev test.

General Dev Test Platforms

  • Latest macOS, Chrome and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers
  • Latest Chrome OS, Chrome

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ariel-phet
Copy link
Contributor

@KatieWoe this would be the next priority after Gas properties testing

@arouinfar
Copy link
Contributor

arouinfar commented Jul 30, 2019

@samreid dev.9 of Waves Intro includes the "Sound Effect" checkbox for the light source sonification. Since the sound design (except for Play Tone) has been deferred for 1.0, this checkbox should not be included in the simulation.

EDIT: For the purposes of this dev test, it may be acceptable to test with the lightSonificationCheckbox=false query parameter.

samreid added a commit to phetsims/wave-interference that referenced this issue Jul 30, 2019
@samreid samreid changed the title Dev Test: wave-interference/2.0.0-dev.6 and wave-intro/1.0.0-dev.9 Dev Test: wave-interference/2.0.0-dev.7 and wave-intro/1.0.0-dev.10 Jul 30, 2019
@samreid
Copy link
Member Author

samreid commented Jul 30, 2019

Thanks @arouinfar, I published dev.7 and dev.10 to remove the "Sound Effect" button for this dev test. @KatieWoe please be aware I incremented these versions for testing.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 6, 2019

Large amount of lag on 4th screen in Edge is fairly large. I'm guessing we're not concerned enough for an issue @ariel-phet?

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 6, 2019

QA is done

@samreid
Copy link
Member Author

samreid commented Aug 7, 2019

@KatieWoe I didn't notice any comments specifically related to "Waves Intro" and wanted to double check that it was included during this testing.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 7, 2019

@samreid yes it was. A few of the issues do say "applies to both sims" or only applies to ___, etc.

@samreid
Copy link
Member Author

samreid commented Aug 7, 2019

Excellent, thanks for confirming. I'll leave this issue open to track the related issues until we're ready for RC.

@KatieWoe KatieWoe removed their assignment Aug 7, 2019
@samreid
Copy link
Member Author

samreid commented Aug 13, 2019

All issues discovered during dev testing have been closed or deferred, thanks! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

4 participants