Only show light sound effect button when ?fullSonification, see phets…

…ims/qa#389
phetsims · Jul 30, 2019 · d2479f9 · d2479f9
1 parent 5a078dd
commit d2479f9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/js/common/view/WaveInterferenceControlPanel.js b/js/common/view/WaveInterferenceControlPanel.js
@@ -27,6 +27,7 @@ define( require => {
   const intensityString = require( 'string!WAVE_INTERFERENCE/intensity' );
   const playToneString = require( 'string!WAVE_INTERFERENCE/playTone' );
   const screenString = require( 'string!WAVE_INTERFERENCE/screen' );
+  const soundEffectString = require( 'string!WAVE_INTERFERENCE/soundEffect' );
 
   class WaveInterferenceControlPanel extends WaveInterferencePanel {
 
@@ -172,7 +173,7 @@ define( require => {
 
       const createLightSonificationCheckbox = () => {
         return new WaveInterferenceCheckbox(
-          new WaveInterferenceText( 'Sound Effect' ),
+          new WaveInterferenceText( soundEffectString ),
           model.lightScene.soundEffectEnabledProperty, {
             audioEnabled: options.supportsSound,
             top: screenCheckbox.bottom + CHECKBOX_SPACING,
@@ -202,7 +203,7 @@ define( require => {
           // Screen & Intensity graph should only be available for light scenes. Remove it from water and sound.
           ...( scene === model.lightScene ? [ screenCheckbox ] : [] ),
           ...( scene === model.lightScene && options.showIntensityCheckbox ? [ intensityCheckbox ] : [] ),
-          ...( scene === model.lightScene && WaveInterferenceQueryParameters.lightSonificationCheckbox ? [ createLightSonificationCheckbox() ] : [] )
+          ...( scene === model.lightScene && WaveInterferenceQueryParameters.fullSonification && WaveInterferenceQueryParameters.lightSonificationCheckbox ? [ createLightSonificationCheckbox() ] : [] )
         ];
       } );
 

diff --git a/wave-interference-strings_en.json b/wave-interference-strings_en.json
@@ -184,5 +184,8 @@
   },
   "lightGenerator": {
     "value": "Light Generator"
+  },
+  "soundEffect": {
+    "value": "Sound Effect"
   }
 }