Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the tones right? #423

Closed
KatieWoe opened this issue Aug 6, 2019 · 2 comments
Closed

Are the tones right? #423

KatieWoe opened this issue Aug 6, 2019 · 2 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 6, 2019

For phetsims/qa#389
The Play Tones sound doesn't seem quite right to me, but I may be doing something wrong.
If you go to sound and use the default frequency (in the middle), and calculate the hz frequency using the timer, you get about 376 hz. However, the sound that plays seems rather different than that tone.
https://drive.google.com/file/d/1Ux4wMKboR-EBmlvz0G_d0GsHq20ecGlR/view?usp=sharing

@samreid
Copy link
Member

samreid commented Aug 7, 2019

I measured one wavefront and got 2.99ms on the timer, using the "step" button to get to the next peak. This works out to be 1/0.00299 =
334.44816053511704 Hz. I tried 330Hz in https://www.szynalski.com/tone-generator/ and it sounded about the same pitch as the sim. I think the largest source of error in this measurement is getting the timer stopped at about the right time.

@samreid samreid assigned KatieWoe and unassigned samreid Aug 7, 2019
@arouinfar
Copy link
Contributor

At the default frequency I measured the time for 3 complete cycles, and got 9.04 ms, which corresponds to 332 Hz. The actual value is 330 Hz, so I'd say there's pretty good agreement.

I think the largest source of error in this measurement is getting the timer stopped at about the right time.

Absolutely. I find that pausing the sim, starting the source & timer, and then stepping through to be the most accurate way to collect data, but it's still not perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants