Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sim won't open in IE #424

Closed
KatieWoe opened this issue Aug 6, 2019 · 4 comments
Closed

Sim won't open in IE #424

KatieWoe opened this issue Aug 6, 2019 · 4 comments
Assignees
@KatieWoe
Labels
status:ready-for-review type:bug

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 6, 2019

For phetsims/qa#389
The main sim won't load in IE.
Error in console:
SCRIPT438: Object doesn't support property or method 'ellipse'
@samreid
Copy link
Member

samreid commented Aug 7, 2019

The problem is happening around this part:

image

@samreid
Copy link
Member

samreid commented Aug 7, 2019

According to https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/ellipse, context.ellipse is not supported on IE. I'll look for another solution.

samreid added a commit that referenced this issue Aug 7, 2019
@samreid
Render ellipse as scaled circle on IE, see #424
a1a1c98
samreid added a commit that referenced this issue Aug 7, 2019
@samreid
Render ellipse as scaled circle on IE for disorder scene, see #424
8403c40
@samreid
Copy link
Member

samreid commented Aug 7, 2019 •
edited
Loading

Proposed fix committed and checks out OK on my IE11 on bootcamp. I tested this new dev version https://phet-dev.colorado.edu/html/wave-interference/2.0.0-dev.10/phet/ . @KatieWoe can you please verify on that or on phettest?

UPDATE: please close if all is well.

@samreid samreid assigned KatieWoe and unassigned samreid Aug 7, 2019
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Aug 7, 2019

Dev test opens alright

@KatieWoe KatieWoe closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @KatieWoe