-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC Test: Masses and Springs 1.0.0-rc.2 #153
Comments
@KatieWoe this sim should be current top testing priority As noted, the fix for phetsims/joist#470 has been included in this sim, so it should be thoroughly vetted by QA during this RC test |
@Denz1994 rc.2 doesn't appear to include any of the pixel polishing done in phetsims/masses-and-springs#292, though the changes still appear in master. @KatieWoe also reopened phetsims/masses-and-springs#289 noting that things were fixed in master, but not rc.2. Is it possible that rc.2 was improperly built? |
Yeah, @lmulhall-phet and I have been noticing this too. |
…1 after bad rc deploy phetsims/qa#153
A revised rc.2 has been deployed with the appropriate changes. The old rc.2 was not merged from master before the build so the changes did not get applied. The above links have been updated. Sorry for the build error. |
QA is finished |
@Denz1994 back to you. Looks like this sim might need one more RC, but can probably be more of a spot check. Let's discuss once you address the final issues. |
The last issue for this test was closed. I'm closing this issue. Thanks QA team! |
@ariel-phet, @arouinfar, Masses And Springs 1.0.0-rc.2 is ready for RC testing.
Link to Sim
Link to iFrame
Test Matrix
Issues to Verify:
This is the second RC test for M&S. Please verify that phetsims/joist#470 has been fixed in this sim. (Liam's Edit: It looks like the home screen icon moving up/down issue isn't going to be fixed for this RC.)
Please verify:
If any new issues are found, please note them in https://github.com/phetsims/masses-and-springs/issues and reference this issue.
Tagging @ariel-phet for prioritization.
The text was updated successfully, but these errors were encountered: