Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Masses and Springs 1.0.0-rc.2 #153

Closed
8 tasks done
Denz1994 opened this issue Jul 24, 2018 · 8 comments
Closed
8 tasks done

RC Test: Masses and Springs 1.0.0-rc.2 #153

Denz1994 opened this issue Jul 24, 2018 · 8 comments
Assignees

Comments

@Denz1994
Copy link
Contributor

Denz1994 commented Jul 24, 2018

@ariel-phet, @arouinfar, Masses And Springs 1.0.0-rc.2 is ready for RC testing.

Link to Sim

Link to iFrame

Test Matrix

Issues to Verify:

This is the second RC test for M&S. Please verify that phetsims/joist#470 has been fixed in this sim. (Liam's Edit: It looks like the home screen icon moving up/down issue isn't going to be fixed for this RC.)

Please verify:

  • stringTest=double (all strings doubled)
  • stringTest=long (exceptionally long strings)
  • stringTest=X (short strings)
  • stringTest=rtl (right-to-left)
  • stringTest=xss (test passes if sim does not redirect, OK if sim crashes or fails to fully start)
  • showPointerAreas (touchArea=red, mouseArea=blue)
  • Full screen test
  • Screenshot test

If any new issues are found, please note them in https://github.com/phetsims/masses-and-springs/issues and reference this issue.

Tagging @ariel-phet for prioritization.

@ariel-phet
Copy link
Contributor

@KatieWoe this sim should be current top testing priority

As noted, the fix for phetsims/joist#470 has been included in this sim, so it should be thoroughly vetted by QA during this RC test

@arouinfar
Copy link
Contributor

@Denz1994 rc.2 doesn't appear to include any of the pixel polishing done in phetsims/masses-and-springs#292, though the changes still appear in master. @KatieWoe also reopened phetsims/masses-and-springs#289 noting that things were fixed in master, but not rc.2. Is it possible that rc.2 was improperly built?

@arouinfar
Copy link
Contributor

arouinfar commented Jul 24, 2018

@KatieWoe it's probably best if the QA team holds off on testing rc.2 until we hear back from @Denz1994. I'm seeing lots of changes that were made post-rc.1 that, for whatever reason, haven't made it into rc.2

@KatieWoe
Copy link
Contributor

Yeah, @lmulhall-phet and I have been noticing this too.

Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Jul 25, 2018
Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Jul 25, 2018
@Denz1994
Copy link
Contributor Author

A revised rc.2 has been deployed with the appropriate changes. The old rc.2 was not merged from master before the build so the changes did not get applied. The above links have been updated. Sorry for the build error.

@KatieWoe
Copy link
Contributor

QA is finished

@ariel-phet
Copy link
Contributor

@Denz1994 back to you. Looks like this sim might need one more RC, but can probably be more of a spot check. Let's discuss once you address the final issues.

@Denz1994
Copy link
Contributor Author

Denz1994 commented Aug 8, 2018

The last issue for this test was closed. I'm closing this issue. Thanks QA team!

@Denz1994 Denz1994 closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants