stringTest=long makes lines not aligned with associated strings

[ghost]

Noticed this while looking at #303...

The natural length, mass equilibrium, and movable lines become slightly misaligned when stringTest=long is used:

Default for contrast:

This does not, however, occur with stringTest=double, so I don't know if we care about this... Are there languages where two words can be about 50 characters long?

For phetsims/qa/issues/153.

[arouinfar]

Good catch @lmulhall-phet. I think the purpose of ?stringTest=long is to reveal layout issues when strings are pushed to/beyond their limit, and this certainly looks like a layout issue to me.

[ghost]

Ah, I see. That makes much more sense. Thanks, @arouinfar.

[ghost]

Also, on the Energy screen, a slider thumb can overlap with a string:

[Denz1994]

@arouinfar Can you review master? I added some alignBBox/alignGroup refactors.

[arouinfar]

@Denz1994 the strings and icons now remained aligned under i18n, which is great.

However, it looks like the Displacement and Natural Length icons are missing from the Lab screen, but they're correctly appearing on the Energy screen.

It also looks like #305 (comment) hasn't been addressed.

[Denz1994]

You are right @arouinfar, what about master now?

[arouinfar]

Looks good, thanks @Denz1994!

[KatieWoe]

This issue seems to be appearing in RC 3 phetsims/qa/issues/165

[KatieWoe]

Taking a second look at this, I'm no longer sure. It looks better than it used to, but still seems a bit misaligned to me.

[arouinfar]

@KatieWoe I think the Displacement and Natural Length icons are grouped as a single icon, which is then centered with respect to the checkbox.

It looks a bit misaligned for ?stringTest=long but less so for ?stringTest=double (which is more realistic for a sim translation).

@Denz1994 if the icons are indeed grouped, I think we can close this issue. Otherwise, please investigate.

[Denz1994]

The icons are grouped with their labels respectively. The slight difference here is one, we have a bracket included in the label group so it isn't as uniform as the other three labels. Two, the arrow isn't the same size as the line symbols in height so there is a bit more variability in the symbol size as well.

I am going to agree with closing this issue on the basis that the symbols for the bracketed options are centered with respect to the symbols' sizes and the bracket group.