Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Masses and Springs 1.0.0-rc.3 #165

Closed
8 tasks done
Denz1994 opened this issue Aug 8, 2018 · 5 comments
Closed
8 tasks done

RC Test: Masses and Springs 1.0.0-rc.3 #165

Denz1994 opened this issue Aug 8, 2018 · 5 comments
Assignees

Comments

@Denz1994
Copy link
Contributor

Denz1994 commented Aug 8, 2018

@ariel-phet, @arouinfar, Masses And Springs 1.0.0-rc.3 is ready for RC testing. It is @ariel-phet's suggestion to test on only a few core platforms and not all of our supported platforms.

Link to Sim

Link to iFrame

Test Matrix

Issues to Verify: There are no outstanding issues to verify.

This is the third RC test for M&S. The main focus here is on view layout and alignments as there were refactors done for view components since the last RC test.

Please verify:

  • stringTest=double (all strings doubled)
  • stringTest=long (exceptionally long strings)
  • stringTest=X (short strings)
  • stringTest=rtl (right-to-left)
  • stringTest=xss (test passes if sim does not redirect, OK if sim crashes or fails to fully start)
  • showPointerAreas (touchArea=red, mouseArea=blue)
  • Full screen test
  • Screenshot test

If any new issues are found, please note them in https://github.com/phetsims/masses-and-springs/issues and reference this issue.

Tagging @ariel-phet for prioritization.

@Denz1994
Copy link
Contributor Author

Denz1994 commented Aug 8, 2018

Assigning myself to assure build was successful.

@Denz1994
Copy link
Contributor Author

Denz1994 commented Aug 8, 2018

This isn't a build error. Master was merged into RC.3 and was up to date with the latest master. The bug for phetsims/masses-and-springs/issues/290 was reintroduced via phetsims/masses-and-springs@98951d4, not due to a bad build.

@arouinfar
Copy link
Contributor

Since there've been a lot changes stemming from the recent RC cycles, I should probably do a detailed review of rc.3 to make sure everything's still looking good. Self-assigning.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 10, 2018

QA is finished. LOL won't open in OS 10.12 Safari as pointed out in phetsims/special-ops/issues/116. However, this is a problem with LOL and not the sim.

@arouinfar
Copy link
Contributor

@Denz1994 I found a few small things, documented in the issues above. Everything else is looking great!

Thanks to @KatieWoe and the QA team for a speedy RC. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants