Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Gravity" heading should not disappear when on Planet X #289

Closed
arouinfar opened this issue Jun 12, 2018 · 5 comments
Closed

"Gravity" heading should not disappear when on Planet X #289

arouinfar opened this issue Jun 12, 2018 · 5 comments
Assignees
@Denz1994
Labels
status:ready-for-review type:bug

Comments

@arouinfar
Copy link

For phetsims/qa#129

Switching to Planet X correctly replaces the slider with the string, "What is the value of gravity?". However, the "Gravity" heading should remain visible, as in Pendulum Lab (bottom).
image

image
Denz1994 added a commit that referenced this issue Jun 25, 2018
@Denz1994
Gravity title is always visible. #289 Also there were many alignment …
0626a96 
…changes to the gravityAndDampingPanel content.
@Denz1994 Denz1994 assigned arouinfar and unassigned Denz1994 Jun 25, 2018
@Denz1994
Copy link
Contributor

Could you check this in master @arouinfar? I believe this was fixed.

@arouinfar
Copy link
Author

👍

@KatieWoe KatieWoe reopened this Jul 24, 2018
@KatieWoe
Copy link
Contributor

This no longer seems to be fixed in RC2
It does seem to be fixed in master.
for phetsims/qa/issues/153

@arouinfar arouinfar mentioned this issue Jul 24, 2018
Closed
8 tasks
@arouinfar arouinfar removed their assignment Jul 24, 2018
@KatieWoe
Copy link
Contributor

Closing

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 8, 2018 •
edited
Loading

This no longer seems to be fixed in rc.3 For phetsims/qa/issues/165
Edit: Sorry, wrong issue

@KatieWoe KatieWoe reopened this Aug 8, 2018
@KatieWoe KatieWoe closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Denz1994 Denz1994

Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arouinfar @Denz1994 @KatieWoe