stringTest=double makes radio buttons touch edge of toolbox

[ghost]

Here's the issue:

Seen on all browsers + macOS.

For phetsims/qa/issues/153.

[arouinfar]

I think what's happening is that the radio buttons are remaining left-aligned with "Constant Parameter" which collides with the panel border under i18n. Maintaining alignment is desirable, but losing the padding between the strings and panel border isn't.

@Denz1994 I think this panel could be allowed to expand to the left to provide room for long translations, similar to what was done in #293. When the panel expands, the padding between the left side of the strings and panel border should remain the same.

[Denz1994]

Can you review master @arouinfar? The logic for aligning the panel contents has been slightly refactored.

[arouinfar]

@Denz1994 the strings are no longer colliding with the border, but it looks like panel isn't expanding, as requested.

[Denz1994]

Can you review master now @arouinfar? I need a second eye for the expansion.

[arouinfar]

@Denz1994 for i18n the new panel width is looking good. However, the panel should only get wider for i18n, but otherwise it can keep the same width as it had before (match spring constant panel width).

[arouinfar]

Here are some screenshots for comparison.

To summarize

• Spring Length and Spring Constant panels should normally have the same width
• Spring Length (and Spring Constant, if that makes things easier) can expand up to 50 px for i18n
• Constant Parameter title/radio group has too much left padding in master, but rc.2 had the desired layout:
  

[Denz1994]

After further investigation, there are a few things to consider. The contents of the panel is already being scaled because the panel is too small for the default sizes of the contents (hSlider in particular). If we change the maxWidth of the panel it will change the scale of its contents automatically because the contents will have more space to expand to its default size.

There is a potential workaround that includes making the panel larger to fit its content.

Capacitor Lab: Basics has a similar behavior, but the difference is that the content's panel fits within the panel. In fact the panel is relatively large compared to M&S.

Design question: Do we want to enlarge the panels to allow for the panel to expand more pixels before shrinking its contents. There will be a good amount of changes to alignments that would require another round of testing for i18n issues. Thoughts @arouinfar and @ariel-phet?

Note this suggested change also applies to #293

[Denz1994]

In a discussion with @ariel-phet. Check for input from @jonathanolson. If the panels require that they are enlarged, then create a general issue where appropriate. Otherwise, work towards refactoring a workaround that allows for more pixel space.

[Denz1994]

In a meeting with @ariel-phet and @jonathanolson it was confirmed that the contents of the panel need to fit within the panel, by either making the contents smaller or making the panel a bit larger. @ariel-phet thought it was best to let the panels expand a bit more. @arouinfar can you check if master is good for review?

[arouinfar]

It's looking pretty good to me! Thanks @Denz1994.

[arouinfar]

@Denz1994 this is occurring in 1.0. @DianaTavares showed me this:

[Denz1994]

The spring options panel on the second scene of the intro screen, described above, has been refactored to use alignBox/alignGroup. This change has a similar structure to the general sim option panels found on the right side of each screen. Assigning to @arouinfar to review.

[arouinfar]

@Denz1994 master is looking good now

[Nancy-Salpepi]

This looks good in 1.1.0-dev.2.
I see a couple of other string test problems that I will make new issues for.

[jbphet]

Thanks, closing.