-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dynamic locale #239
Comments
Code specific to ph-scale-basics was completed in the above commit. |
Next on my list, so raising priority. |
Before doing this work, I published 1.6.0-dev.3 for |
In the above commits, I did the low-hanging fruit -- the StringProperties that are passed directly to a Text/RichText constructor. I can already tell that this sim is going to have significant layout problems. |
@arouinfar ready for review. |
@pixelzoom overall things look good in ph-scale. I didn't review the links to the StringProperties in the view components, since it sounds like that work is still outstanding. Let me know if you need any guidance before you begin. I found a few issues with dynamic layout:
In ph-scale-basics, I'm seeing every single ph-scale string. Since there isn't a way to re-add the additional screens in Basics, these strings seem completely irrelevant. For example, many of these StringProperties relate to later screens. I wasn't sure how this was being handled in rosetta, so I compared to the Translation Utility. The strings specific to pH Scale (e.g. |
This is a general problem, not specific to ph-scale-basicis. A sim's PhET-iO API currently includes every string Property, from every dependency repo, regardless of whether those strings are using in the sim. Tracking in https://github.com/phetsims/phet-io/issues/1877. |
I've created separate issues for each things that @arouinfar reported in #239 (comment). Closing. |
... similar to what was done in phetsims/natural-selection#319.
This also includes ph-scale-basics.
The text was updated successfully, but these errors were encountered: