PhET-iO design review for 1.6 release #241

pixelzoom · 2022-08-30T01:40:37Z

#239 (add support for dynamic locale) will certainly result in many API changes, and there have been many common-code API changes and additions. So this sim will require a full design review of the PhET-iO API.

This includes ph-scale-basics.

…e#241

pixelzoom · 2022-09-02T15:28:54Z

Related to phetsims/tandem#267 ... Tandem names for all Text nodes now have a "Text" suffix, for example "labelText", "titleText". This is an API change. See above commits.

arouinfar · 2022-10-06T16:57:12Z

Getting started on this now. Review will focus on:

Review dynamic layout/strings, Add support for dynamic locale #239
Verify stringProperties are linked appropriately in the view - Add links to stringProperty #251
Review phetioFeatured elements and update overrides as needed
- see https://github.com/phetsims/phet-io-sim-specific/issues/11#issuecomment-1258969845 for instructions
Update examples.md for ph-scale and ph-scale-basics

arouinfar · 2022-12-02T23:05:54Z

@pixelzoom I would like to feature model.dropper.visibleProperty. There is an example customization that requires hiding the dropper, so it makes sense to make it phetioFeatured: true.

I tried following the steps outlined in https://github.com/phetsims/phet-io-sim-specific/issues/11#issuecomment-1258969845, but it's just too complicated for me. I'll add comments in that issue, but I spent about 30 minutes and then bailed.

@pixelzoom here are the contents of the overrides. Can you please make the commits and regenerate the API files?

ph-scale-phet-io-overrides.js

/* eslint-disable */
window.phet.preloads.phetio.phetioElementsOverrides =
  {
    "phScale.macroScreen.model.autofillEnabledProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.model.dropper.soluteProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.model.dropper.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.model.pHMeter.pHProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.model.solution.pHProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.model.solution.soluteVolumeProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.model.solution.totalVolumeProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.model.solution.waterVolumeProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.view.beakerNode.tickMarks.tickLabels.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.view.beakerNode.tickMarks.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.view.drainFaucetNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.view.neutralIndicatorNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.view.pHMeterNode.pHIndicatorNode.numberDisplay.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.view.volumeIndicatorNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.view.waterFaucetNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.macroScreen.view.waterFaucetNode.waterText.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.autofillEnabledProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.dropper.soluteProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.dropper.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.concentrationH2OProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.concentrationH3OProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.concentrationOHProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.numberOfH2OMoleculesProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.numberOfH3OMoleculesProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.numberOfOHMoleculesProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.pHProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.quantityH2OProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.quantityH3OProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.quantityOHProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.soluteVolumeProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.totalVolumeProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.model.solution.waterVolumeProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.beakerControlPanel.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.beakerNode.tickMarks.tickLabels.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.beakerNode.tickMarks.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.drainFaucetNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.expandedProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.graphControlPanel.graphUnitsSwitch.concentrationText.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.graphControlPanel.graphUnitsSwitch.quantityText.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.graphControlPanel.graphUnitsSwitch.visibleProperty": {
      "phetioFeatured": false
    },
    "phScale.microScreen.view.graphNode.graphScaleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.graphScaleSwitch.linearText.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.graphScaleSwitch.logarithmicText.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.graphUnitsProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.linearGraphNode.indicatorH2ONode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.linearGraphNode.indicatorH3ONode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.linearGraphNode.indicatorOHNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.linearGraphNode.zoomButtonGroup.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.linearGraphNode.zoomButtonGroup.zoomInButton.enabledProperty": {
      "phetioFeatured": false
    },
    "phScale.microScreen.view.graphNode.linearGraphNode.zoomButtonGroup.zoomInButton.visibleProperty": {
      "phetioFeatured": false
    },
    "phScale.microScreen.view.graphNode.linearGraphNode.zoomButtonGroup.zoomOutButton.enabledProperty": {
      "phetioFeatured": false
    },
    "phScale.microScreen.view.graphNode.linearGraphNode.zoomButtonGroup.zoomOutButton.visibleProperty": {
      "phetioFeatured": false
    },
    "phScale.microScreen.view.graphNode.logarithmicGraphNode.indicatorH2ONode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.logarithmicGraphNode.indicatorH3ONode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.logarithmicGraphNode.indicatorOHNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.graphNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.pHAccordionBox.expandedProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.ratioNode.ratioProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.viewProperties.moleculeCountVisibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.viewProperties.ratioVisibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.volumeIndicatorNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.waterFaucetNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.microScreen.view.waterFaucetNode.waterText.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.concentrationH2OProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.concentrationH3OProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.concentrationOHProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.numberOfH2OMoleculesProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.numberOfH3OMoleculesProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.numberOfOHMoleculesProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.pHProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.quantityH2OProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.quantityH3OProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.quantityOHProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.model.solution.totalVolumeProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.beakerControlPanel.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.beakerNode.tickMarks.tickLabels.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.beakerNode.tickMarks.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.graphNode.expandedProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.graphNode.graphControlPanel.graphUnitsSwitch.concentrationText.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.graphNode.graphControlPanel.graphUnitsSwitch.quantityText.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.graphNode.graphControlPanel.graphUnitsSwitch.visibleProperty": {
      "phetioFeatured": false
    },
    "phScale.mySolutionScreen.view.graphNode.graphUnitsProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.graphNode.logarithmicGraphNode.indicatorH2ONode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.graphNode.logarithmicGraphNode.indicatorH3ONode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.graphNode.logarithmicGraphNode.indicatorOHNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.graphNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.pHAccordionBox.expandedProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.ratioNode.ratioProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.viewProperties.moleculeCountVisibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.viewProperties.ratioVisibleProperty": {
      "phetioFeatured": true
    },
    "phScale.mySolutionScreen.view.volumeIndicatorNode.visibleProperty": {
      "phetioFeatured": true
    }
  };

ph-scale-basics-phet-io-overrides.js

/* eslint-disable */
window.phet.preloads.phetio.phetioElementsOverrides =
  {
    "phScaleBasics.macroScreen.model.autofillEnabledProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.model.dropper.soluteProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.model.dropper.visibleProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.model.pHMeter.pHProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.model.solution.pHProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.model.solution.soluteVolumeProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.model.solution.totalVolumeProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.model.solution.waterVolumeProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.view.beakerNode.tickMarks.tickLabels.visibleProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.view.beakerNode.tickMarks.visibleProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.view.drainFaucetNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.view.neutralIndicatorNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.view.pHMeterNode.pHIndicatorNode.numberDisplay.visibleProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.view.volumeIndicatorNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.view.waterFaucetNode.visibleProperty": {
      "phetioFeatured": true
    },
    "phScaleBasics.macroScreen.view.waterFaucetNode.waterText.visibleProperty": {
      "phetioFeatured": true
    }
  };

pixelzoom · 2022-12-02T23:23:36Z

@arouinfar Done - model.dropper.visibleProperty is now featured. Back to you for review.

arouinfar · 2022-12-02T23:40:54Z

Thanks @pixelzoom! Looks good in master. That's it for this issue, closing.

pixelzoom added status:on-hold design:phet-io labels Aug 30, 2022

pixelzoom assigned kathy-phet and arouinfar Aug 30, 2022

pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Sep 2, 2022

use tandem name '*Text' consistently for Text nodes, phetsims/ph-scal…

3646665

…e#241

pixelzoom added a commit that referenced this issue Sep 2, 2022

use tandem name '*Text' consistently for Text nodes, #241

0b1d6e4

arouinfar unassigned kathy-phet Oct 6, 2022

arouinfar removed the status:on-hold label Oct 6, 2022

arouinfar mentioned this issue Oct 6, 2022

Add links to stringProperty #251

Closed

4 tasks

pixelzoom added the status:ready-for-review label Oct 6, 2022

pixelzoom added the status:blocks-sim-publication label Nov 17, 2022

samreid mentioned this issue Nov 22, 2022

Migration rules for 1.6 release #240

Closed

arouinfar assigned pixelzoom and unassigned arouinfar Dec 2, 2022

pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Dec 2, 2022

feature model.dropper.visibleProperty, phetsims/ph-scale#241

ed4222b

pixelzoom added a commit that referenced this issue Dec 2, 2022

feature model.dropper.visibleProperty, #241

c4e6498

pixelzoom assigned arouinfar and unassigned pixelzoom Dec 2, 2022

arouinfar closed this as completed Dec 2, 2022

samreid mentioned this issue Dec 3, 2022

pH Scale - Publish 1.6 with PhET-iO Upgrades #236

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PhET-iO design review for 1.6 release #241

PhET-iO design review for 1.6 release #241

pixelzoom commented Aug 30, 2022 •

edited

Loading

pixelzoom commented Sep 2, 2022

arouinfar commented Oct 6, 2022 •

edited

Loading

arouinfar commented Dec 2, 2022

pixelzoom commented Dec 2, 2022

arouinfar commented Dec 2, 2022

PhET-iO design review for 1.6 release #241

PhET-iO design review for 1.6 release #241

Comments

pixelzoom commented Aug 30, 2022 • edited Loading

pixelzoom commented Sep 2, 2022

arouinfar commented Oct 6, 2022 • edited Loading

arouinfar commented Dec 2, 2022

pixelzoom commented Dec 2, 2022

arouinfar commented Dec 2, 2022

pixelzoom commented Aug 30, 2022 •

edited

Loading

arouinfar commented Oct 6, 2022 •

edited

Loading