Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title on pH meter in Macro screen does not remain centered. #245

Closed
pixelzoom opened this issue Sep 9, 2022 · 2 comments
Closed

Title on pH meter in Macro screen does not remain centered. #245

pixelzoom opened this issue Sep 9, 2022 · 2 comments
Assignees
@arouinfar
Labels
status:ready-for-review type:bug type:i18n

Comments

@pixelzoom
Copy link
Contributor

In #239 (comment), @arouinfar reported:

  1. pHStringProperty - the text does not remain centered and escapes the bounds of the pH Meter.
    image
@pixelzoom pixelzoom self-assigned this Sep 9, 2022
@pixelzoom pixelzoom changed the title Title on pH meter in Macro screen needs a maxWidth. Title on pH meter in Macro screen does not remain centered. Sep 9, 2022
pixelzoom added a commit that referenced this issue Sep 10, 2022
@pixelzoom
keep 'pH' title centered, #245
a528bde
@pixelzoom
Copy link
Contributor Author

@arouinfar ready for review.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Sep 10, 2022
@arouinfar
Copy link
Contributor

Thanks @pixelzoom, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
status:ready-for-review type:bug type:i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @arouinfar