Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal separator in the control panel does not resize when locale is changed. #244

Closed
pixelzoom opened this issue Sep 9, 2022 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

In #239 (comment), @arouinfar reported:

  1. phScale.microScreen.view.beakerControlPanel.separator does not change in size when the panel expands to accommodate long strings. Not sure if this is something that can be handled within the scope of dynamic layout, but wanted to point it out in case this behavior is unexpected or can be corrected. (Feel free to veto if overly complicated.)
    image
@pixelzoom
Copy link
Contributor Author

Resizing of the separator was address in the above commit.

Because of phetsims/scenery#1448, "separator" is now "divider", and that changes the PhET-iO API. This is the 3rd API that I've to change because of this today, and there are more on the way. I don't think it's an improvement. @kathy-phet FYI.

@arouinfar please review the behavior and API changes. The revised phetioIDs are:

phScale.microScreen.view.beakerControlPanel.divider
phScale.microScreen.view.beakerControlPanel.divider.visibleProperty
phScale.mySolutionScreen.view.beakerControlPanel.divider
phScale.mySolutionScreen.view.beakerControlPanel.divider.visibleProperty

@arouinfar
Copy link
Contributor

The dynamic layout issue has been addressed, and I don't see any technical issues with the new phetioIDs. However, we should make a decision about terminology in phetsims/scenery#1448 before closing this out.

image

@pixelzoom
Copy link
Contributor Author

"Separator" terminology was restored in phetsims/scenery#1448, and "separator" tandem names were restored in the above commit.

@arouinfar please review, close if OK. You can verify for searching for "divider" and "separator" in Studio.

@arouinfar
Copy link
Contributor

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants