-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal separator in the control panel does not resize when locale is changed. #244
Comments
Resizing of the separator was address in the above commit. Because of phetsims/scenery#1448, "separator" is now "divider", and that changes the PhET-iO API. This is the 3rd API that I've to change because of this today, and there are more on the way. I don't think it's an improvement. @kathy-phet FYI. @arouinfar please review the behavior and API changes. The revised phetioIDs are:
|
The dynamic layout issue has been addressed, and I don't see any technical issues with the new phetioIDs. However, we should make a decision about terminology in phetsims/scenery#1448 before closing this out. |
"Separator" terminology was restored in phetsims/scenery#1448, and "separator" tandem names were restored in the above commit. @arouinfar please review, close if OK. You can verify for searching for "divider" and "separator" in Studio. |
Looks good, thanks! |
In #239 (comment), @arouinfar reported:
phScale.microScreen.view.beakerControlPanel.separator
does not change in size when the panel expands to accommodate long strings. Not sure if this is something that can be handled within the scope of dynamic layout, but wanted to point it out in case this behavior is unexpected or can be corrected. (Feel free to veto if overly complicated.)The text was updated successfully, but these errors were encountered: