Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address miscellaneous TODOs #29

Closed
pixelzoom opened this issue Jan 15, 2023 · 6 comments
Closed

Address miscellaneous TODOs #29

pixelzoom opened this issue Jan 15, 2023 · 6 comments
Assignees
@chrisklus @zepumph
Labels
status:blocks-sim-publication

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 15, 2023 •
edited
Loading

This issue is a catch-all for miscellaneous TODOs that did not have an associated GitHub issue. This issue covers the number-play, number-compare, number-suite, and counting-common repos.

These TODOs should be triaged for 1.0, identifying which ones need to be addressed. If any of them require significant work, please split out into a new issue.

Assigning to @chrisklus to triage.
@pixelzoom pixelzoom mentioned this issue Jan 15, 2023
Closed
8 tasks
pixelzoom added a commit that referenced this issue Jan 15, 2023
@pixelzoom
TODO #29
f793837
pixelzoom added a commit to phetsims/number-compare that referenced this issue Jan 15, 2023
@pixelzoom
TODO phetsims/number-suite-common#29
bf054d9
pixelzoom added a commit to phetsims/number-play that referenced this issue Jan 15, 2023
@pixelzoom
TODO phetsims/number-suite-common#29
e03ac77
pixelzoom added a commit to phetsims/number-play that referenced this issue Jan 15, 2023
@pixelzoom
https://github.com/phetsims/number-suite-common/issues/29
87eb5ee
@pixelzoom pixelzoom reopened this Jan 15, 2023
@pixelzoom pixelzoom mentioned this issue Jan 15, 2023
Closed
@chrisklus chrisklus mentioned this issue Jan 19, 2023
Closed
@chrisklus
Copy link
Contributor

Adding blocks-sim-publication label to indicate this should be completed before starting Number Compare and Number Play 1.0/1 dev testing.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 22, 2023 •
edited
Loading

I took a quick look at all remaining TODOs. I don't see any that seem essential to address before publishing Number Play or Number Compare (phetsims/number-compare#9) -- i.e. nothing that impacts UX or crashes the sim. @chrisklus you should definitely take a look too. But I'd be OK with changing this issue from "blocks-sim-publication" to "deferred".

chrisklus added a commit to phetsims/number-play that referenced this issue Mar 16, 2023
@chrisklus
Rename returnCountingObjectToBucket -> returnCountingObjectToCreatorN…
059c85f 
…ode, cleanup usages, see phetsims/number-suite-common#29
chrisklus added a commit that referenced this issue Mar 16, 2023
@chrisklus
Rename returnCountingObjectToBucket -> returnCountingObjectToCreatorN…
01988d5 
…ode, cleanup usages, see #29
chrisklus added a commit to phetsims/number-compare that referenced this issue Mar 22, 2023
@chrisklus
Remove unnecessary disabling of UI sounds, phetsims/number-suite-comm…
af0ee84 
…on#29
zepumph added a commit that referenced this issue Mar 28, 2023
@zepumph
simplify two statements into one, #29
fa3f208
chrisklus added a commit that referenced this issue Mar 30, 2023
@chrisklus
Simplifly trail slice, see #29
31e8ed7
chrisklus added a commit to phetsims/counting-common that referenced this issue Mar 30, 2023
@chrisklus
Simplifly trail slice, see phetsims/number-suite-common#29
8218ebb
@zepumph zepumph self-assigned this Mar 31, 2023
This was referenced Mar 31, 2023
Closed
Closed
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph
rename add/remove to TenFrameNode, #29
f119af6
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph
remove dead code, #41 #29
32e53de
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph
simplify stored bound functions (remove TODO), #29
582f9e9
zepumph added a commit to phetsims/counting-common that referenced this issue Mar 31, 2023
@zepumph
simplify stored bound functions (remove TODO), phetsims/number-suite-…
a355571 
…common#29
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph
counting Object->countingObject, add doc to function, #29
976294a
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph
update doc, #29
7d7d62f
@zepumph
Copy link
Member

zepumph commented Mar 31, 2023

I wasn't able to preserve git history for LocaleSwitch, here is the last version when it was still over in number-suite-common. https://github.com/phetsims/number-suite-common/blob/6fd98ef94e1cbc1320d35721983651af37985ac3/js/common/view/LocaleSwitch.ts

zepumph added a commit to phetsims/number-play that referenced this issue Mar 31, 2023
@zepumph
move LocaleSwitch to number-play (lose git history), phetsims/number-…
1d240f2 
…suite-common#29
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph
move LocaleSwitch to number-play (lose git history), #29
e9ca32a
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph
move SymbolType to its own file, #29
d6689d1
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph
factor out similar options and update documentation, #29
850a7ac
@zepumph
Copy link
Member

zepumph commented Mar 31, 2023

Handled a good amount above, we will keep working on them! 11 left.

@zepumph zepumph mentioned this issue Apr 3, 2023
Closed
zepumph added a commit to phetsims/number-compare that referenced this issue Apr 3, 2023
@zepumph
updates to TODOs, phetsims/number-suite-common#29
255be15
zepumph added a commit to phetsims/number-play that referenced this issue Apr 3, 2023
@zepumph
updates to TODOs, phetsims/number-suite-common#29
db6d63a
zepumph added a commit that referenced this issue Apr 3, 2023
@zepumph
updates to TODOs, #29
04c4c03
zepumph added a commit that referenced this issue Apr 3, 2023
@zepumph
rename to boundsProperty, but not in the view, #29
bebf194
zepumph added a commit that referenced this issue Apr 3, 2023
@zepumph
factor out constant, #29
0afd1b9
zepumph added a commit that referenced this issue Apr 3, 2023
@zepumph
factor out constant, #29
b7d272e
@zepumph
Copy link
Member

zepumph commented Apr 3, 2023 •
edited
Loading

  • While factoring out a button length, I was curious if @chrisklus could comment on if this value (20.8) was related to the resetAllButton constant in scenery-phet constants?

https://github.com/phetsims/number-compare/blob/78ed243599e0bd0a4af94d633663bec0a0bf20a9/js/compare/view/BlockValuesNode.ts#L17

zepumph added a commit that referenced this issue Apr 3, 2023
@zepumph
factor out constant, #29
26596cf
zepumph added a commit to phetsims/number-compare that referenced this issue Apr 3, 2023
@zepumph
use a factor for reproducibility, phetsims/number-suite-common#29
7a82086
zepumph added a commit to phetsims/number-play that referenced this issue Apr 3, 2023
@zepumph
move layout logic to a single multilink, phetsims/number-suite-common#29
c647cf8
zepumph added a commit to phetsims/number-play that referenced this issue Apr 3, 2023
@zepumph
doc, phetsims/number-suite-common#29
297759e
chrisklus added a commit that referenced this issue Apr 3, 2023
@chrisklus
Update docs and function name, see #29
0084794
chrisklus added a commit that referenced this issue Apr 3, 2023
@chrisklus
Doc grammar, see #29
c859b14
chrisklus added a commit to phetsims/counting-common that referenced this issue Apr 3, 2023
@chrisklus
Update docs and function name, see phetsims/number-suite-common#29
f200de4
@zepumph
Copy link
Member

zepumph commented Apr 4, 2023

All TODO issues have been moved to side issues or handled in above commits. Closing

@zepumph zepumph closed this as completed Apr 4, 2023
This was referenced Apr 4, 2023
Closed
Closed
Closed
Closed
marlitas pushed a commit that referenced this issue Dec 12, 2024
@zepumph
move LocaleSwitch to number-play (lose git history), #29
e2949b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisklus chrisklus

@zepumph zepumph

Labels
status:blocks-sim-publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @chrisklus @zepumph