Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm best height for WordAccordionBox #200

Closed
zepumph opened this issue Jan 13, 2023 · 1 comment
Closed

Confirm best height for WordAccordionBox #200

zepumph opened this issue Jan 13, 2023 · 1 comment
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jan 13, 2023

Promoting TODO to issue:

// TODO: This is giving weird results...
const heightProperty = new DerivedProperty( [ numberPlayPreferences.showSecondLocaleProperty ], showSecondLocale => {
const shortHeight = height - HEIGHT_ADJUSTMENT;
return showSecondLocale ? shortHeight : height;
} );

@zepumph zepumph self-assigned this Jan 13, 2023
@pixelzoom
Copy link
Contributor

Moved to phetsims/number-suite-common#29, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants