Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to "bucket" #39

Closed
pixelzoom opened this issue Jan 23, 2023 · 2 comments
Closed

References to "bucket" #39

pixelzoom opened this issue Jan 23, 2023 · 2 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 23, 2023

There are 22 references to "bucket" (case insensitive) in number-suite-common and number-play. 13 are in code constructs, 9 are in comments. There are no buckets in these sims. This is confusing, so let's change "bucket" to the correct word for where a counting object originates.

@pixelzoom
Copy link
Contributor Author

I don't feel that this issue is blocking publication.

@zepumph
Copy link
Member

zepumph commented Mar 31, 2023

instead of "bucket" let's call it "creator node" or "creatorNode" or perhaps "counting creator node" in some cases.

This cleanup doesn't block, but we still may get to it before publication. Noting #29 as a superset of this.

@zepumph zepumph self-assigned this Mar 31, 2023
zepumph added a commit to phetsims/number-play that referenced this issue Mar 31, 2023
zepumph added a commit that referenced this issue Mar 31, 2023
@zepumph zepumph closed this as completed Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants