Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full bounds of CountingObject needed before view has been created #65

Closed
zepumph opened this issue Apr 3, 2023 · 2 comments
Closed
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Apr 3, 2023

Promoting a TODO to an issue:

//TODO https://github.com/phetsims/number-suite-common/issues/29 This is kind of a band-aid to keep the grouped objects' handles from sticking out of the top of the play
// area since they are not yet included in countingObject.localBounds above without a view created
const countingAreaBoundsMinY = this.groupingEnabledProperty.value ? 30 : 0;

in CountingArea.createCountingObjectFromCreatorNode, we have some magic numbers and algorithm that is trying to guess at the size of the "handle" sticking out above the objects. We should try to remedy this with:

  1. Ideally positioning logic resolving after we have a view
  2. Share a constant between view and model at the very least.
zepumph added a commit that referenced this issue Apr 3, 2023
chrisklus added a commit to phetsims/counting-common that referenced this issue Apr 3, 2023
@zepumph
Copy link
Member Author

zepumph commented Apr 4, 2023

Promoted its own issue from #29

chrisklus added a commit to phetsims/counting-common that referenced this issue Apr 5, 2023
@chrisklus
Copy link
Contributor

@zepumph and I were able to fix this in a nice way in the above commits. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants