-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helptext and grab/release alerts for Measure Distance button #141
Comments
Unassigning until Ruler becomes a higher priority. |
See also, phetsims/scenery-phet#536 |
@zepumph there are 2 tables with all the context responses I think we will need. Please see Interaction & Design Details for Measure Distance Button section in the design doc. |
Please reassign if you have questions. |
From phetsims/scenery-phet#536 (comment), we aren't able to change the grab/drag interaction to support touch better. We are stuck with "double tap and hold" for application roles with mobile screen readers. The next steps for this issue seem to be:
@terracoda over to you. These were what I thought came out of the meeting. Let me know if this is incorrect or incomplete. |
I got all the above done @zepumph |
Back over to you :-) |
First I will do the changes to the PDOM structure and content. I still think here is the best place for that. |
…release ruler on jump home, phetsims/gravity-force-lab#141
…release ruler on jump home, phetsims/gravity-force-lab#141
I'm a little on the fence about whether or not to add alerts to master, or to a branch. This is because we are unsure if time will permit us to add these. I think for now I will proceed in master, but in a modular ruler alert specific type so if could be easy to omit it from a publication. |
@zepumph, I think all the alerts I have provides thus far should be good for master. |
@zepumph, when you are done and have a chance can you publish a dev version, so I can test on iphone, too. |
Alerts when the ruler is grabbed should be implemented now. @terracoda please review. |
@zepumph, the grabbed responses are working on keyboard, but as we discussed this morning I made a few tweaks to the actual phrases. Change:
To:
As you noted as well, the I haven't tested on mobile yet. |
@zepumph, is this ready to test on mobile voice over, too? |
I made the phrase changes, and removed the "move in four directions" role description. I also removed it from faradays law, as likely that will become "movable" when we get there too.
Over in #140 (comment) you gave good initial feedback from gesture testing. I'm going to close this issue and carry on in sub issues from that feedback. Please reopen if there is anything else for this issue. We can open new issues for future bugs. |
Re-writing this issue rather than posting a new one as there are several cross linked issues.
The "Grab Ruler" button has been renamed to be a "Measure Distance" button
Related to #138 and #140, so @terracoda will make sure those issues are up-to-date-/and still relevant.
With the name change, non-visual users should understand what the button is for, and since they already have access to the distance value in other ways, they should be able to figure out that it is not important to use this Measure Distance, button.
That said, they will be able to if they want to.
Please see the Control Area section and the Interaction Support details in the design doc for the initial help text, and grab and release context responses (alerts).
I am working on the more context responses and useful location descriptions for the grabbed ruler.
The text was updated successfully, but these errors were encountered: