Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helptext and grab/release alerts for Measure Distance button #141

Closed
terracoda opened this issue Jan 16, 2019 · 15 comments
Closed

Helptext and grab/release alerts for Measure Distance button #141

terracoda opened this issue Jan 16, 2019 · 15 comments
Assignees

Comments

@terracoda
Copy link
Contributor

terracoda commented Jan 16, 2019

Re-writing this issue rather than posting a new one as there are several cross linked issues.

The "Grab Ruler" button has been renamed to be a "Measure Distance" button

Related to #138 and #140, so @terracoda will make sure those issues are up-to-date-/and still relevant.

With the name change, non-visual users should understand what the button is for, and since they already have access to the distance value in other ways, they should be able to figure out that it is not important to use this Measure Distance, button.

That said, they will be able to if they want to.

Please see the Control Area section and the Interaction Support details in the design doc for the initial help text, and grab and release context responses (alerts).

I am working on the more context responses and useful location descriptions for the grabbed ruler.

@zepumph
Copy link
Member

zepumph commented Jan 17, 2019

Unassigning until Ruler becomes a higher priority.

@terracoda
Copy link
Contributor Author

See also, phetsims/scenery-phet#536

@terracoda terracoda changed the title Ruler helptext and grab ruler alerts Helptext and grab/release alerts for Measure Distance button Oct 18, 2019
@terracoda terracoda self-assigned this Oct 18, 2019
@terracoda
Copy link
Contributor Author

@zepumph there are 2 tables with all the context responses I think we will need. Please see Interaction & Design Details for Measure Distance Button section in the design doc.

@terracoda terracoda assigned zepumph and unassigned terracoda Oct 18, 2019
@terracoda
Copy link
Contributor Author

Please reassign if you have questions.

@zepumph
Copy link
Member

zepumph commented Oct 21, 2019

From phetsims/scenery-phet#536 (comment), we aren't able to change the grab/drag interaction to support touch better. We are stuck with "double tap and hold" for application roles with mobile screen readers. The next steps for this issue seem to be:

@terracoda over to you. These were what I thought came out of the meeting. Let me know if this is incorrect or incomplete.

@terracoda
Copy link
Contributor Author

I got all the above done @zepumph
Please see the table of contents and everything marked (New).
Some stuff is in PDOM are and some stuff is below that.

@terracoda
Copy link
Contributor Author

Back over to you :-)

@zepumph
Copy link
Member

zepumph commented Oct 29, 2019

First I will do the changes to the PDOM structure and content. I still think here is the best place for that.

zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Oct 29, 2019
zepumph added a commit to phetsims/scenery-phet that referenced this issue Oct 29, 2019
@zepumph
Copy link
Member

zepumph commented Oct 29, 2019

I'm a little on the fence about whether or not to add alerts to master, or to a branch. This is because we are unsure if time will permit us to add these. I think for now I will proceed in master, but in a modular ruler alert specific type so if could be easy to omit it from a publication.

@terracoda
Copy link
Contributor Author

terracoda commented Oct 30, 2019

@zepumph, I think all the alerts I have provides thus far should be good for master.
The alerts to come wold be for movement with the arrow keys. Those alerts may be something we decide not to publish if we can't get them just right.

@terracoda
Copy link
Contributor Author

@zepumph, when you are done and have a chance can you publish a dev version, so I can test on iphone, too.

@zepumph
Copy link
Member

zepumph commented Nov 4, 2019

Alerts when the ruler is grabbed should be implemented now. @terracoda please review.

@terracoda
Copy link
Contributor Author

@zepumph, the grabbed responses are working on keyboard, but as we discussed this morning I made a few tweaks to the actual phrases.

Change:

Grabbed. In home position below spheres. Centers of spheres 4 ‪meters‬ apart. Press J plus C keys to jump ruler and align zero mark at center of m1. Space to release.

To:

Grabbed. In home position below mass spheres. Centers 4 ‪meters‬ apart. Press J plus C keys to jump ruler to center of m1. Space to release.

As you noted as well, the aria-roledescription text needs to be changed to "movable".

I haven't tested on mobile yet.

@terracoda
Copy link
Contributor Author

@zepumph, is this ready to test on mobile voice over, too?

@terracoda terracoda removed their assignment Nov 6, 2019
zepumph added a commit that referenced this issue Nov 11, 2019
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 11, 2019
@zepumph
Copy link
Member

zepumph commented Nov 11, 2019

I made the phrase changes, and removed the "move in four directions" role description. I also removed it from faradays law, as likely that will become "movable" when we get there too.

@zepumph, is this ready to test on mobile voice over, too?

Over in #140 (comment) you gave good initial feedback from gesture testing. I'm going to close this issue and carry on in sub issues from that feedback. Please reopen if there is anything else for this issue. We can open new issues for future bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants