Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vertical ruler regions #185

Closed
zepumph opened this issue Nov 5, 2019 · 3 comments
Closed

Fix vertical ruler regions #185

zepumph opened this issue Nov 5, 2019 · 3 comments
Assignees
@terracoda
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Nov 5, 2019

The first pass at implementation was done in #141, but they still need to be tweaked. First I will create a visual way to display them.
@zepumph zepumph self-assigned this Nov 5, 2019
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 5, 2019
@zepumph
add showRulerRegions query parameter, phetsims/gravity-force-lab#185
f064b39
zepumph added a commit that referenced this issue Nov 5, 2019
@zepumph
add showRulerRegions query parameter, #185
74f4db6
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 5, 2019
@zepumph
Fix ruler regions, log regions when showing ruler regions, phetsims/g…
1ec78f9 
…ravity-force-lab#185
zepumph added a commit that referenced this issue Nov 5, 2019
@zepumph
Fix ruler regions, log regions when showing ruler regions, #185
7335a41
zepumph added a commit that referenced this issue Nov 5, 2019
@zepumph
add doc, #185
aaf5ea9
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 5, 2019
@zepumph
add doc, phetsims/gravity-force-lab#185
f2794da
@zepumph
Copy link
Member Author

zepumph commented Nov 5, 2019

@terracoda, these vertical regions for the ruler are ready for review now. The best way to test is by adding the showRulerRegions query parameter. This will do a few things:

  • Add horizontal lines at the boundaries
  • add crosshairs on the ruler so you can see the point that is being tested
  • prints the region names to the console, so you can see them in the developer tools.

Let me know what you think!

@zepumph zepumph assigned terracoda and unassigned zepumph Nov 5, 2019
@terracoda
Copy link
Contributor

The vertical ruler regions look great @zepumph!

@terracoda
Copy link
Contributor

Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terracoda terracoda

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terracoda @zepumph