Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Interaction: Measure Distance Ruler - Combining Release and Grab strings #205

Closed
terracoda opened this issue Nov 20, 2019 · 7 comments
Assignees

Comments

@terracoda
Copy link
Contributor

In #141 the Grab alert was corrected.

However, recent changes seem to have combined "Released" and "Grabbed" strings into the grab response.

Screen Shot 2019-11-19 at 9 18 51 PM

@zepumph, could you have a look. It might just be a copy/paste error.

@terracoda
Copy link
Contributor Author

And "Released" is said twice on an actual release, so maybe these extra "Release" strings are creeping in from the gesture implementation?

Screen Shot 2019-11-19 at 10 17 56 PM

@terracoda
Copy link
Contributor Author

@zepumph, actually, I think the double "Release" was just a timing glitch. I think only one "Release" is being spoken on the actual release interaction, and there is an erroneous "Release" string being added to the grab interaction response.

@zepumph
Copy link
Member

zepumph commented Nov 20, 2019

I think that #203 (comment) actually applies to this issue:

@jessegreenberg I think this is because we added the down/up listeners, but we are also handling the gesture case on the PDOM side. Likely we want to just have this handled by the general presslistener that we added recently. I'll implement

@zepumph
Copy link
Member

zepumph commented Nov 26, 2019

Yes I get this sometimes. It is not because of any of the alerts. I think it has to do with the kinks we are still working out in successfully grabbing/releasing the ruler each time the user intends to. (like #201 and #210). I would like to try to sort out at least #210 and then see if this sounds any better.

I was having trouble when it felt like I wasn't able to grab it successfully each time, and then after trying a few times I was then able to grab it (if that sounds confusing it is because I'm confused). I'll look in on this after #210.

@terracoda
Copy link
Contributor Author

terracoda commented Nov 27, 2019

@zepumph, I seem to get "Release." on grab, and "Grabbed." on release in addition to the correct strings.

It seems it could be related to yours and @jessegreenberg comment in #205 (comment)

Good luck. (corrected typo)
Just an FYI, still happening on 2.2.0-dev.21

@zepumph
Copy link
Member

zepumph commented Dec 30, 2019

@terracoda are you still getting this bug? I know @jessegreenberg has done a lot of work on the grab/drag interaction in the last month.

@zepumph zepumph assigned terracoda and unassigned zepumph Dec 30, 2019
@terracoda
Copy link
Contributor Author

terracoda commented Dec 30, 2019

Good question, I'll check.
In latest dev version 2.2.0-dev.23

I am getting correct "Grabbed" and "Released." And at the right times!
I checked Mac OS High Sierra and iOS 13.3

I am closing this issues.
Thanks for checking @zepumph !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants