Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gesture: Ruler helptext is read out multiple times #203

Closed
terracoda opened this issue Nov 20, 2019 · 7 comments
Closed

Gesture: Ruler helptext is read out multiple times #203

terracoda opened this issue Nov 20, 2019 · 7 comments

Comments

@terracoda
Copy link
Contributor

In 2.2.0-dev.18, the help text delivered when the Measure Distance Ruler gains gesture focus is read out three times instead of just once.

@terracoda
Copy link
Contributor Author

@zepumph, I am sorry I do not know why. Could you check that the help text content appears in the code in a single place.

@terracoda
Copy link
Contributor Author

This is a serious problem. It the help text is being read out 6 times now.
Are we using aria-describedby? If so, maybe it doesn't work well on mobile safari? Maybe we should try without it and see what VO does.

@terracoda
Copy link
Contributor Author

@zepumph I marked high priority as I can't use the sim with that kind of repetition going on. And I do not know how to debug it. (Sorry)

@terracoda terracoda changed the title Gesture: Ruler helptext is read out multple times Gesture: Ruler helptext is read out multiple times Nov 20, 2019
@zepumph
Copy link
Member

zepumph commented Nov 20, 2019

@jessegreenberg I think this is because we added the down/up listeners, but we are also handling the gesture case on the PDOM side. Likely we want to just have this handled by the general presslistener that we added recently. I'll implement

@zepumph
Copy link
Member

zepumph commented Nov 26, 2019

I am able to reproduce this on 2.2.0-dev.18, but not on master. @terracoda please confirm this is fixed from other work @jessegreenberg and I have been doing in the dev version I will send you this evening.

@terracoda
Copy link
Contributor Author

@zepumph, recent commits tot he ruler interaction have made it much much better over all. I am no longer hearing repeated help text. AND, I get no auto help text (no aria-describedby) after 2 grabs which I find really nice (thanks!).

There is still some quirkyness:

  • Distance string in initial grab alert gets cut off.
  • Ruler is a bit jumpy, meaning it can just move to another pot on the screen when I try and grab it.

I will open new issues for these as something to watch for.

@zepumph
Copy link
Member

zepumph commented Dec 5, 2019

Ruler is a bit jumpy, meaning it can just move to another pot on the screen when I try and grab it.

Note that this is a bug from #191, and should be fixed before publication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants