-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 2 jumping Keyboard Shortcuts for the grabbed ruler #138
Comments
@zepumph, this is a new issue so assigning to you, but no rush as you transfer over to this sim. |
For now I'm going to try to keep only high priority issues assigned to me to keep a better todo list; as such unassigning for now. |
On hold until #140 is sorted out. |
@zepumph, since this has to do with ruler, I think it can be put on hold until quarter 4. |
@zepumph, I think J plus C is going to be a better shortcut than J plus S. I don't think you have implemented these shortcuts yet, but we do have them them in them noted Keyboard Shortcuts. In addition to implementing J plus C as the Shortcut, please be sure to update:
|
@terracoda I implemented this above. You can either review this piece now, or perhaps wait and do everything together. One question I had was about the ordering of hotkeys. I found that this doesn't work when I hold 'H' and then hold 'J'. Is that expected? |
@terracoda noticed that sometimes you have to press the hot keys more than once to get them to fire. For example in the following sequence, I reliably needed to press "J + C" twice, only the second time did it move: J+C |
|
Today, @terracoda said she would look over things, and then let me know when these jumping alerts are ready for implementation. Unassigning until then. |
@zepumph, apologies for the delay. I reviewed and tweaked a couple of the phrases in the tables. The responses (alerts) are ready to go. |
There have been implemented (I think) as we want them, but because of #189, they aren't yet working. I'm going to head over there now. |
Oops, I was adding the wrong utterance to the queue. These should be working now. @terracoda this is now ready for review. |
@zepumph, these shortcuts work and sound great! Sounds like it is done to me. Nice work! |
In issue #134 we decided that the following 2 "jumping" keyboard shortcuts for the ruler interaction would be helpful:
For more details see the Measure Distance button in the Control Area of the PDOM section and the Interaction & Design Details for the Measure Distance button.
Edit Oct 18, 2019:
The text was updated successfully, but these errors were encountered: