Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruler only moves 1/2 of the time #189

Closed
KatieWoe opened this issue Nov 7, 2019 · 8 comments
Closed

Ruler only moves 1/2 of the time #189

KatieWoe opened this issue Nov 7, 2019 · 8 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 7, 2019

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#455
When trying to drag the ruler, either with a mouse or touch screen it only grabs on every other time.

Visuals
rulerwontdrag

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Gravity Force Lab‬
URL: https://phet-dev.colorado.edu/html/gravity-force-lab/2.2.0-dev.16/phet/gravity-force-lab_all_phet.html?showPointerAreas
Version: 2.2.0-dev.16 2019-11-06 21:45:42 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.87 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Nov 7, 2019

Not restricted by platform

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Nov 8, 2019

a11y view may give hint as to what is happening:
behavea11y

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Nov 8, 2019

behavea11y2

@zepumph
Copy link
Member

zepumph commented Nov 11, 2019

This is happening because we added this.node.interruptInput() as part of the baseInteractionUpdate. This was added for a reason relating to the keyboard drag listener. I can't exactly remember. @jessegreenberg can we talk about this together tomorrow. It isn't obvious to me currently how we will support the cross product of device listeners support (mouse/keyboard/gesture) and features (alerts/pdom updates). Right now it doesn't seem like they can all exist together.

@zepumph
Copy link
Member

zepumph commented Nov 11, 2019

The interrupt line was added over in #186.

@zepumph
Copy link
Member

zepumph commented Nov 12, 2019

We found that this isn't happening for BASE because the pointer listener is added to the parent of the Node that gets the grab/drag interaction.

@zepumph
Copy link
Member

zepumph commented Nov 12, 2019

The issue here is that we were interrupting all listeners on the Node. GrabDragInteraction shouldn't be able to interrupt everything, only the listeners that were going to be removed when converting to/from grabbable/draggable. The change was implemented above, and this bug has been fixed. Thanks @jessegreenberg for the idea!

@zepumph
Copy link
Member

zepumph commented Nov 12, 2019

I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants