-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruler only moves 1/2 of the time #189
Comments
Not restricted by platform |
This is happening because we added |
The interrupt line was added over in #186. |
We found that this isn't happening for BASE because the pointer listener is added to the parent of the Node that gets the grab/drag interaction. |
The issue here is that we were interrupting all listeners on the Node. GrabDragInteraction shouldn't be able to interrupt everything, only the listeners that were going to be removed when converting to/from grabbable/draggable. The change was implemented above, and this bug has been fixed. Thanks @jessegreenberg for the idea! |
I'm going to close this issue. |
Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#455
When trying to drag the ruler, either with a mouse or touch screen it only grabs on every other time.
Visuals
Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: Gravity Force Lab
URL: https://phet-dev.colorado.edu/html/gravity-force-lab/2.2.0-dev.16/phet/gravity-force-lab_all_phet.html?showPointerAreas
Version: 2.2.0-dev.16 2019-11-06 21:45:42 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.87 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}
The text was updated successfully, but these errors were encountered: