You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on phetsims/gravity-force-lab#189, we noticed that that bug in common code wasn't effecting the BalloonNode. The reason is that the GrabDragInteraction is being added to a sub "image" node, while the moveableDragHandler is added directly to the BalloonNode. @jessegreenberg can you explain this discrepancy? I'm not sure what the benefit is to have these on separate Nodes, but it seems more confusing.
The text was updated successfully, but these errors were encountered:
Coming back to this because I had to review listener code for #522. The GrabDragHandler modifies a child of the BalloonNode rather than BalloonNode directly because the BalloonNode itself has content for the PDOM that should contain the PDOM content related to the GrabDragInteraction. It accomplishes HTML that looks like
<div><h3>Yellow Balloon</h3><p>A description of the balloon's location, charges, velocity, etc...</p><div><button>Grab Yellow Balloon</button> // button related to GrabDragInteraction
<p>Description specific to GrabDRagInteraction
</div></div>
While working on phetsims/gravity-force-lab#189, we noticed that that bug in common code wasn't effecting the BalloonNode. The reason is that the GrabDragInteraction is being added to a sub "image" node, while the
moveableDragHandler
is added directly to theBalloonNode
. @jessegreenberg can you explain this discrepancy? I'm not sure what the benefit is to have these on separate Nodes, but it seems more confusing.The text was updated successfully, but these errors were encountered: