Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the studio tree #917

Closed
samreid opened this issue Jan 3, 2023 · 7 comments
Closed

Review the studio tree #917

samreid opened this issue Jan 3, 2023 · 7 comments
Assignees
@arouinfar
Milestone
Full initial PhET...

Comments

@samreid
Copy link
Member

samreid commented Jan 3, 2023

We would like to take a close look at the studio tree to make sure it is well-designed.
@samreid
Copy link
Member Author

samreid commented Jan 5, 2023

Some notes about trouble in the studio tree in #858 (comment), regarding the voltmeter/ammeter panel.

This was referenced Jan 5, 2023
Closed
Closed
Closed
This was referenced Jan 13, 2023
Closed
Closed
Closed
matthew-blackman pushed a commit that referenced this issue Jan 13, 2023
@UniverseAndMore
Uninstrument ammeterIconModel in SensorToolbox - see #917
4c4410c
This was referenced Jan 13, 2023
Closed
Closed
This was referenced Jan 17, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
matthew-blackman pushed a commit to phetsims/circuit-construction-kit-dc that referenced this issue Jan 19, 2023
@UniverseAndMore
Feature voltmeterToolNode - see phetsims/circuit-construction-kit-com…
2c38870 
…mon#917
samreid added a commit that referenced this issue Jan 20, 2023
@samreid
Rename voltageNumberControl => batteryVoltageNumberControl, see #917
37fe3f5
samreid added a commit that referenced this issue Jan 20, 2023
@samreid
Rename currentRatingControl => fuseCurrentRatingControl, see #917
bccd1ce
samreid added a commit that referenced this issue Jan 20, 2023
@samreid
Rename repairFuseButton => fuseRepairButton, see #917
1872c0e
samreid added a commit that referenced this issue Jan 20, 2023
@samreid
Rename reverseBatteryButton => batteryReverseButton, see #917
da2b504
samreid added a commit that referenced this issue Jan 20, 2023
@samreid
Remove trash button from SwitchReadoutNode, see #917
d87b220
@arouinfar arouinfar mentioned this issue Jan 20, 2023
Open
samreid added a commit that referenced this issue Jan 20, 2023
@samreid
Add phetioFeatured to the CCKCAccordionBox.expandedProperty, see #917
5a2ab86
samreid added a commit that referenced this issue Jan 20, 2023
@samreid
Uninstrument the arrowNode, see #917
83fa1d3
@samreid samreid mentioned this issue Jan 21, 2023
Closed
@samreid
Copy link
Member Author

samreid commented Jan 21, 2023

For my reference, notes are being taken in:

https://docs.google.com/document/d/1z8ECC0PIi7gGQ8WRpp3mFwzX9SrXH48EOJW3gSYii90/edit

This was referenced Jan 24, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@samreid
Copy link
Member Author

samreid commented Feb 2, 2023

Are all reported issues tracked elsewhere? Can this issue be closed?

@arouinfar
Copy link
Contributor

Yes, let's close.

@matthew-blackman
Copy link

fuseRepairButton visibleProperty should not be readonly

@arouinfar arouinfar removed their assignment Feb 6, 2023
matthew-blackman pushed a commit that referenced this issue Feb 6, 2023
@UniverseAndMore
Remove readonly and uninstrument enabledProperty from FuseRepairButto…
00f2927 
…n - see #917
@matthew-blackman
Copy link

@arouinfar FuseRepairButton ready for your review, please confirm and then close if it looks good.

@arouinfar arouinfar mentioned this issue Feb 7, 2023
Closed
@arouinfar
Copy link
Contributor

@matthew-blackman it's a bit more complicated than we thought, so I opened up #956.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
None yet
Projects
None yet
Milestone
Full initial PhET-iO release: DC
Development

No branches or pull requests
3 participants
@samreid @arouinfar @matthew-blackman