Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourceResistanceProperty & wireResistivityProperty instrumented range should match slider ranges #928

Closed
matthew-blackman opened this issue Jan 13, 2023 · 1 comment
Closed

sourceResistanceProperty & wireResistivityProperty instrumented range should match slider ranges #928

matthew-blackman opened this issue Jan 13, 2023 · 1 comment
Assignees
@samreid
Labels
status:ready-for-review
Milestone
Full initial PhET...

Comments

@matthew-blackman
Copy link

matthew-blackman commented Jan 13, 2023 •
edited
Loading

Including these properties on the Intro screen adds flexibility, but the range is off. Source resistance range is +/- infinity, can we make it 0.0001-10,000? This matches the maximum of the high-R resistor, so the model should be able to handle this. Wire resistivity: range should match slider range

#917
@matthew-blackman matthew-blackman self-assigned this Jan 13, 2023
matthew-blackman pushed a commit that referenced this issue Jan 19, 2023
@UniverseAndMore
Put min and max wire resistivity into CCKCContants and implement in W…
28623e5 
…ireResistivityControl range - see #928
matthew-blackman pushed a commit that referenced this issue Jan 19, 2023
@UniverseAndMore
Add source resistance range into sourceResistanceProperty - see #928
2c3c482
@samreid
Copy link
Member

samreid commented Feb 2, 2023

Looks great, thanks! Closing.

@samreid samreid closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
status:ready-for-review
Projects
None yet
Milestone
Full initial PhET-iO release: DC
Development

No branches or pull requests
2 participants
@samreid @matthew-blackman