-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common prefix for high-R/high-V circuit elements #936
Comments
It seems anyone could help on this. We want to rename the any tandems beginning with |
This looks good to me, nice work. I'm wondering if we will want to change |
I like the prefix 'is' as a style pattern for boolean options. Will update 'extreme' to 'isExtreme' and 'real' to 'isReal'. |
Excellent, looks great, thanks, closing. |
I also noticed a constant that looks like it should be renamed to match: const isExtreme = selectedCircuitElement.resistorType === ResistorType.HIGH_RESISTANCE_RESISTOR; Perhaps rename |
Fixed, closing. |
Related to #917
We currently use
highResistance
andhighVoltage
as prefixes for associated resistors, bulbs, and batteries. In addition to being verbose, these prefixes aren't always accurate. A standard bulb (max R = 120 Ω) can have a larger resistance than a high-R bulb (min R = 100 Ω). A common prefix would simplify the language and result in these elements being grouped together in the tree.In discussions with @matthew-blackman and @samreid, we tentatively liked "extreme". @samreid please proceed with this change. If you think of any alternatives to "extreme" please let me know. I think it evokes the right idea, but there may be a better term we haven't thought of yet.
The text was updated successfully, but these errors were encountered: