Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstrument switch isEditableProperty #931

Closed
arouinfar opened this issue Jan 17, 2023 · 3 comments
Closed

Uninstrument switch isEditableProperty #931

arouinfar opened this issue Jan 17, 2023 · 3 comments
Assignees
@samreid
Labels
status:ready-for-review
Milestone
Full initial PhET...

Comments

@arouinfar
Copy link
Contributor

Related to #917

Most circuit components are adjustable in some way (e.g. resistance, voltage, current rating).
image

To prevent users from editing a circuit component, clients can set isEditableProperty to false, which would hide the slider in the screenshot above.

Switches do not have a tunable Property (like resistance) so isEditableProperty doesn't actually do anything. Can we get rid of it @samreid?
@samreid
Copy link
Member

samreid commented Jan 19, 2023

We would probably add a ternary operator where isEditableProperty is instrumented--to use Tandem.OPT_OUT for Switch circuit elements.

@matthew-blackman matthew-blackman removed their assignment Jan 19, 2023
matthew-blackman pushed a commit that referenced this issue Jan 19, 2023
@UniverseAndMore
Uninstrument isEditableProperty for Switches - see #931
a50eaee
matthew-blackman pushed a commit to phetsims/circuit-construction-kit-dc that referenced this issue Jan 19, 2023
@UniverseAndMore
Uninstrument isEditableProperty for Switches - see phetsims/circuit-c…
e990449 
…onstruction-kit-common#931
@matthew-blackman
Copy link

@samreid ready for review

@samreid
Copy link
Member

samreid commented Jan 20, 2023

Excellent, nice work @matthew-blackman. Closing.

@samreid samreid closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
status:ready-for-review
Projects
None yet
Milestone
Full initial PhET-iO release: DC
Development

No branches or pull requests
3 participants
@samreid @arouinfar @matthew-blackman