-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate "centralized code with options" vs "extendable base classes" for this sim #153
Comments
This issue has some overlap with #152 |
…ents instead of through options, see: #153
I feel the last place where this issue applies is in the readouts on the left of the accordion box for screens 2-3. @marlitas was working on that, I believe. |
…tomRepresentationCheckboxGroup, see: #153
Completed the readouts in accordion boxes. Over to @samreid for review, and perhaps closing this off together. |
Commits above look good. The proposed changes in #170 also match this pattern. I feel this issue can be closed. |
Reopening because there is a TODO marked for this issue. |
All TODOs addressed. Ready for review. In my opinion, I feel there are still some places that could use refactoring like this, but we can address them if/when discovered. @marlitas can you please review recent commits and close if all is ok? Or comment if you know of other places that should be refactored? |
Reviewed with @samreid. Any other work regarding this topic will be done on an as-needed basis. We are ready to close. |
While implementing #149, it seems the sim is more based on options and having parent types implement things (like the accordion box), but this is making it difficult to adjust and customize for the Variability screen. For instance, we need to add different checkboxes, an info button and move the left edge to the right. Should all of this be through options, or should the VariabilityScreenView create its own CAVAccordionBox that it customized appropriately? I want to discuss this with @marlitas and/or @matthew-blackman before working on it, because there are tradeoffs either way and it would be good to discuss before spending a lot of time on it.
The text was updated successfully, but these errors were encountered: