Rename checkbox creation methods, see #153

phetsims · Apr 26, 2023 · 4cbaf3e · 4cbaf3e
1 parent 3012ebe
commit 4cbaf3e
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 19 deletions.
diff --git a/js/common/view/BottomRepresentationCheckboxGroup.ts b/js/common/view/BottomRepresentationCheckboxGroup.ts
@@ -30,7 +30,7 @@ const TEXT_OPTIONS = {
 
 export default class BottomRepresentationCheckboxGroup extends VerticalCheckboxGroup {
 
-  private static newGridBox( text: Node, icon: Node, iconGroup: AlignGroup ): GridBox {
+  private static createGridBox( text: Node, icon: Node, iconGroup: AlignGroup ): GridBox {
     return new GridBox( {
       stretch: true,
       spacing: 5,
@@ -44,10 +44,10 @@ export default class BottomRepresentationCheckboxGroup extends VerticalCheckboxG
     } );
   }
 
-  public static getVariabilityCheckbox( alignGroup: AlignGroup, model: VariabilityModel ): VerticalCheckboxGroupItem {
+  public static getVariabilityCheckboxItem( alignGroup: AlignGroup, model: VariabilityModel ): VerticalCheckboxGroupItem {
     return {
       createNode: ( tandem: Tandem ) => {
-        return BottomRepresentationCheckboxGroup.newGridBox(
+        return BottomRepresentationCheckboxGroup.createGridBox(
           new Text( CenterAndVariabilityStrings.variabilityStringProperty, TEXT_OPTIONS ),
           NumberLineNode.createMeanIndicatorNode( true, true ),
           alignGroup
@@ -58,10 +58,10 @@ export default class BottomRepresentationCheckboxGroup extends VerticalCheckboxG
     };
   }
 
-  public static getMedianCheckbox( alignGroup: AlignGroup, model: CAVModel ): VerticalCheckboxGroupItem {
+  public static getMedianCheckboxItem( alignGroup: AlignGroup, model: CAVModel ): VerticalCheckboxGroupItem {
     return {
       createNode: ( tandem: Tandem ) => {
-        return BottomRepresentationCheckboxGroup.newGridBox(
+        return BottomRepresentationCheckboxGroup.createGridBox(
           new Text( CenterAndVariabilityStrings.medianStringProperty, TEXT_OPTIONS ),
           new ArrowNode( 0, 0, 0, 27, {
             fill: CAVColors.medianColorProperty,
@@ -77,9 +77,9 @@ export default class BottomRepresentationCheckboxGroup extends VerticalCheckboxG
     };
   }
 
-  public static getMeanCheckbox( alignGroup: AlignGroup, model: CAVModel ): VerticalCheckboxGroupItem {
+  public static getMeanCheckboxItem( alignGroup: AlignGroup, model: CAVModel ): VerticalCheckboxGroupItem {
     return {
-      createNode: ( tandem: Tandem ) => BottomRepresentationCheckboxGroup.newGridBox( new Text( CenterAndVariabilityStrings.meanStringProperty, TEXT_OPTIONS ),
+      createNode: ( tandem: Tandem ) => BottomRepresentationCheckboxGroup.createGridBox( new Text( CenterAndVariabilityStrings.meanStringProperty, TEXT_OPTIONS ),
         NumberLineNode.createMeanIndicatorNode( true, true ), alignGroup ),
       property: model.isShowingPlayAreaMeanProperty,
       tandemName: 'meanCheckbox'
@@ -90,7 +90,7 @@ export default class BottomRepresentationCheckboxGroup extends VerticalCheckboxG
                                        tandemName: string, alignGroup: AlignGroup ): VerticalCheckboxGroupItem {
     return {
       createNode: ( tandem: Tandem ) => {
-        return BottomRepresentationCheckboxGroup.newGridBox(
+        return BottomRepresentationCheckboxGroup.createGridBox(
           new Text( stringProperty, TEXT_OPTIONS ),
           new PredictionThumbNode( { color: color, maxHeight: 20, pickable: false } ),
           alignGroup );
@@ -100,7 +100,7 @@ export default class BottomRepresentationCheckboxGroup extends VerticalCheckboxG
     };
   }
 
-  public static getPredictMedianCheckbox( alignGroup: AlignGroup, model: CAVModel ): VerticalCheckboxGroupItem {
+  public static getPredictMedianCheckboxItem( alignGroup: AlignGroup, model: CAVModel ): VerticalCheckboxGroupItem {
     return BottomRepresentationCheckboxGroup.createPredictionItem(
       model.isShowingMedianPredictionProperty,
       CenterAndVariabilityStrings.predictMedianStringProperty,
@@ -111,7 +111,7 @@ export default class BottomRepresentationCheckboxGroup extends VerticalCheckboxG
     );
   }
 
-  public static getPredictMeanCheckbox( alignGroup: AlignGroup, model: CAVModel ): VerticalCheckboxGroupItem {
+  public static getPredictMeanCheckboxItem( alignGroup: AlignGroup, model: CAVModel ): VerticalCheckboxGroupItem {
     return BottomRepresentationCheckboxGroup.createPredictionItem(
       model.isShowingMeanPredictionProperty,
       CenterAndVariabilityStrings.predictMeanStringProperty,

diff --git a/js/mean-and-median/view/MeanAndMedianScreenView.ts b/js/mean-and-median/view/MeanAndMedianScreenView.ts
@@ -49,10 +49,10 @@ export default class MeanAndMedianScreenView extends CAVScreenView {
 
     const iconGroup = new AlignGroup();
     const bottomCheckboxGroup = new VerticalCheckboxGroup( [
-      BottomRepresentationCheckboxGroup.getPredictMedianCheckbox( iconGroup, model ),
-      BottomRepresentationCheckboxGroup.getPredictMeanCheckbox( iconGroup, model ),
-      BottomRepresentationCheckboxGroup.getMedianCheckbox( iconGroup, model ),
-      BottomRepresentationCheckboxGroup.getMeanCheckbox( iconGroup, model )
+      BottomRepresentationCheckboxGroup.getPredictMedianCheckboxItem( iconGroup, model ),
+      BottomRepresentationCheckboxGroup.getPredictMeanCheckboxItem( iconGroup, model ),
+      BottomRepresentationCheckboxGroup.getMedianCheckboxItem( iconGroup, model ),
+      BottomRepresentationCheckboxGroup.getMeanCheckboxItem( iconGroup, model )
     ], {
       tandem: options.tandem.createTandem( 'bottomCheckboxGroup' )
     } );

diff --git a/js/median/view/MedianScreenView.ts b/js/median/view/MedianScreenView.ts
@@ -46,8 +46,8 @@ export default class MedianScreenView extends CAVScreenView {
 
     const iconGroup = new AlignGroup();
     const bottomCheckboxGroup = new VerticalCheckboxGroup( [
-      BottomRepresentationCheckboxGroup.getPredictMedianCheckbox( iconGroup, model ),
-      BottomRepresentationCheckboxGroup.getMedianCheckbox( iconGroup, model )
+      BottomRepresentationCheckboxGroup.getPredictMedianCheckboxItem( iconGroup, model ),
+      BottomRepresentationCheckboxGroup.getMedianCheckboxItem( iconGroup, model )
     ], {
       tandem: options.tandem.createTandem( 'bottomCheckboxGroup' )
     } );

diff --git a/js/variability/view/VariabilityScreenView.ts b/js/variability/view/VariabilityScreenView.ts
@@ -93,9 +93,9 @@ export default class VariabilityScreenView extends CAVScreenView {
 
     const iconGroup = new AlignGroup();
     const bottomCheckboxGroup = new VerticalCheckboxGroup( [
-      BottomRepresentationCheckboxGroup.getVariabilityCheckbox( iconGroup, model ),
-      BottomRepresentationCheckboxGroup.getMedianCheckbox( iconGroup, model ),
-      BottomRepresentationCheckboxGroup.getMeanCheckbox( iconGroup, model )
+      BottomRepresentationCheckboxGroup.getVariabilityCheckboxItem( iconGroup, model ),
+      BottomRepresentationCheckboxGroup.getMedianCheckboxItem( iconGroup, model ),
+      BottomRepresentationCheckboxGroup.getMeanCheckboxItem( iconGroup, model )
     ], {
       tandem: options.tandem.createTandem( 'bottomCheckboxGroup' )
     } );